Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve integration tests #1289

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Improve integration tests #1289

merged 1 commit into from
Oct 26, 2023

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Oct 26, 2023

What does this PR do?

This change to the main pom.xml adds "exports" and "opens" argLines to the IT tests to prevent recurring errors during the integration tests.

Motivation

Errors happening during integration tests.

Additional Notes

I also replaced the = with a also for the basic tests as this seems more common.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca merged commit 1256104 into ArcadeData:main Oct 26, 2023
6 of 8 checks passed
@lvca
Copy link
Contributor

lvca commented Oct 26, 2023

Great, thanks!

@lvca lvca added the bug Something isn't working label Oct 26, 2023
@lvca lvca added this to the 23.10.1 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gramian gramian

Labels
bug Something isn't working
Projects
None yet
Milestone
23.10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gramian @lvca