Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make "size" method also applicable to strings #1528

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Fix: make "size" method also applicable to strings #1528

merged 1 commit into from
Mar 28, 2024

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Mar 28, 2024

What does this PR do?

This change makes the size method report the size of strings.

Additional Notes

This also makes the length method redundant. And particularly the length method does not work the same way for non-strings.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca self-requested a review March 28, 2024 11:23
@lvca lvca added this to the 24.3.1 milestone Mar 28, 2024
@gramian gramian marked this pull request as ready for review March 28, 2024 14:42
@mergify mergify bot merged commit 8a111db into ArcadeData:main Mar 28, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvca lvca lvca approved these changes

Assignees

@gramian gramian

Labels
None yet
Projects
None yet
Milestone
24.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gramian @lvca