Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain multiple command-line args for console script #1648

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Jul 8, 2024

What does this PR do?

This changes the way command-line arguments are passed from the console script to java (Linux and MacOS) from using $* (all arguments as one string) to $@ (arguments as array of strings), see https://tldp.org/LDP/abs/html/refcards.html .

Motivation

The change is necessary to be able to pass multiple arguments, otherwise the console cannot detect switches.

Additional Notes

I do not know and cannot test if this problem is also present on Windows.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca merged commit 60aa024 into ArcadeData:main Jul 8, 2024
6 of 7 checks passed
@lvca
Copy link
Contributor

lvca commented Jul 8, 2024

Thanks!

@lvca lvca added the bug Something isn't working label Jul 8, 2024
@lvca lvca added this to the 24.6.1 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants