Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Update index.js #48

Merged
merged 1 commit into from
Oct 7, 2014
Merged

Update index.js #48

merged 1 commit into from
Oct 7, 2014

Conversation

TJRoger
Copy link
Contributor

@TJRoger TJRoger commented Oct 7, 2014

ToAccountID fix

@TJRoger
Update index.js
bad5c00 
ToAccountID fix
@rjackson
Copy link
Member

rjackson commented Oct 7, 2014

Forgive me, but I don't quite understand the purpose of this change. What was the problem with ToAccountID?

@TJRoger
Copy link
Contributor Author

TJRoger commented Oct 7, 2014

@RJacksonm1 The result seems incorrect. There is an extra zero after the calculated accountID string.

@rjackson
Copy link
Member

rjackson commented Oct 7, 2014

Oh, the code was appending "0"? 😆

Thanks for the fix!

@TJRoger
Copy link
Contributor Author

TJRoger commented Oct 7, 2014

@RJacksonm1 Yes. And I am wondering why do you add "0" to the result?

@rjackson
Copy link
Member

rjackson commented Oct 7, 2014

I honestly have no idea, but I assume there was a data-type related reason. Looks like the ToAccountID method was added by @paralin with 68d1621

@rjackson rjackson merged commit bad5c00 into Arcana:master Oct 7, 2014
@rjackson rjackson mentioned this pull request Oct 8, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TJRoger @rjackson