Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add feedback_control_of_siso_system #1

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat:add feedback_control_of_siso_system #1

wants to merge 4 commits into from

Conversation

tomtomApp
Copy link
Contributor

@tomtomApp tomtomApp commented Mar 23, 2024 •
edited
Loading

概要

  • SISO系のシステムの極配置に基づく状態フィードバック制御
  • はじめての現代制御理論の例9.1を実装

変更点

  • feedback_control_of_siso_system.cppの新規追加
  • git submodeleを活用し、cpp_roboticsを追加

確認内容

  • colcon build
  • 時間応答を出力し、教科書図9.1と同様の結果であることを確認

@tomtomApp tomtomApp self-assigned this Mar 23, 2024
@tomtomApp tomtomApp closed this Mar 25, 2024
@tomtomApp tomtomApp reopened this Mar 25, 2024
@tomtomApp tomtomApp marked this pull request as draft March 25, 2024 23:38
@tomtomApp tomtomApp marked this pull request as ready for review March 25, 2024 23:39
@tomtomApp tomtomApp marked this pull request as draft March 25, 2024 23:40
@tomtomApp tomtomApp marked this pull request as ready for review March 25, 2024 23:40
Ramune6110
Ramune6110 requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@Ramune6110 Ramune6110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【要修正】

  • .gitmodulesでarcanain_modern_control_tutorialを対象から外す
    基本的にsubmodule化するのは、自リポジトリ以外のため、今回の場合はcpp_roboticsのみでOK※そもそもsubmodleは自リポジトリ以外のリポジトリの内容を取り込んで活用する際に使用されるものなので

@Ramune6110 Ramune6110 mentioned this pull request Apr 30, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ramune6110 Ramune6110 Ramune6110 requested changes

Assignees

@tomtomApp tomtomApp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomtomApp @Ramune6110