Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 Rhyming Puzzles Added #14 #38

Merged
merged 2 commits into from
Oct 23, 2019
Merged

3 Rhyming Puzzles Added #14 #38

merged 2 commits into from
Oct 23, 2019

Conversation

wajeehsheikh
Copy link

Hi,

As instructed, I added three new rhymes to the puzzles.js. I hope they are good enough to be merged.
Thank you,
Wajeeh

Arcaster42
Arcaster42 requested changes Oct 23, 2019
View reviewed changes
Copy link
Owner

@Arcaster42 Arcaster42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great rhymes! Thanks for putting in time to do this. Please review the comments for some slight changes, and then we should be able to merge it in.

src/js/puzzles.js Outdated Show resolved Hide resolved
src/js/puzzles.js Outdated Show resolved Hide resolved
src/js/puzzles.js Outdated Show resolved Hide resolved
Arcaster42
Arcaster42 approved these changes Oct 23, 2019
View reviewed changes
Copy link
Owner

@Arcaster42 Arcaster42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@Arcaster42 Arcaster42 merged commit 826c5ea into Arcaster42:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcaster42 Arcaster42 Arcaster42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wajeehsheikh @Arcaster42