LADX: fix modifying item pool in pre_fill #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el-u
reviewed
Jul 30, 2023
ThePhar
added
the
is: bug/fix
el-u
approved these changes
Aug 5, 2023
|
Sounds like this is related to #1460? |
There was a problem hiding this comment.
I believe this will break plando on Tarin's Gift (Mabe Village). Is this expected?
(Especially if we move it to create_items,) enumerate(self.multiworld.itempool) should be replaced by a local list of candidates, because iterating over all of multiworld is kinda slow and gets slower with each added slot.
|
In my ER branch I've rewritten to do exactly that -
https://github.com/ArchipelagoMW/Archipelago/pull/1613/files#diff-3810d5b98b98412cb09c53bf2d31f49f7c56de2993b988e4471fd9cbf32dfaecR520
…On Fri, Oct 27, 2023 at 3:24 AM black-sliver ***@***.***> wrote:
***@***.**** commented on this pull request.
I believe this will break plando on Tarin's Gift (Mabe Village). Is this
expected?
(Especially if we move it to create_items,)
enumerate(self.multiworld.itempool) should be replaced by a local list of
candidates, because iterating over all of multiworld is kinda slow and gets
slower with each added slot.
—
Reply to this email directly, view it on GitHub
<#2060 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6TRTCNMZ6AOODA7YSWH2LYBODVBAVCNFSM6AAAAAA25MXLHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBRGQ3DCMZUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Does this PR need to wait on #1613 then? |
ScipioWright
added
the
waiting-on: author
Berserker66
approved these changes
Mar 3, 2024
github-actions
bot
removed
the
waiting-on: author
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The enforced start item was happening a bit too early, this moves it into create_items
How was this tested?
Genned a few times, ran the test in the other branch
If this makes graphical changes, please attach screenshots.