Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: implement APProcedurePatch and APTokenMixin #2536

Merged
merged 33 commits into from
Mar 19, 2024
Merged

Core: implement APProcedurePatch and APTokenMixin #2536

merged 33 commits into from
Mar 19, 2024

Commits on Jul 21, 2023

  1. initial work on procedure patch

    @Silvris
    Silvris committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    3fbbb4f View commit details
    Browse the repository at this point in the history

  2. more flexibility 

    load default procedure for version 5 patches
add args for procedure
add default extension for tokens and bsdiff
allow specifying additional required extensions for generation
    @Silvris
    Silvris committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e0bc4cf View commit details
    Browse the repository at this point in the history

  3. pushing current changes to go fix tloz bug

    @Silvris
    Silvris committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    dac5e5a View commit details
    Browse the repository at this point in the history

  4. move tokens into a separate inheritable class

    @Silvris
    Silvris committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    18ede71 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. forgot the commit to remove token from ProcedurePatch

    @Silvris
    Silvris committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    be74233 View commit details
    Browse the repository at this point in the history

  2. further cleaning from bad commit

    @Silvris
    Silvris committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    1fa8e72 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. start on docstrings

    @Silvris
    Silvris committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ce35826 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. further work on docstrings and typing

    @Silvris
    Silvris committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    f88ccd1 View commit details
    Browse the repository at this point in the history

  2. improve docstrings

    @Silvris
    Silvris committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    6bed682 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge branch 'ArchipelagoMW:main' into instruction_patch_clean

    @Silvris
    Silvris committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8e2738b View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. fix incorrect docstring

    @Silvris
    Silvris committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    06f05a4 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. Merge remote-tracking branch 'upstream/main' into instruction_patch_c… 

    …lean
    @Silvris
    Silvris committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    82ff4aa View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge remote-tracking branch 'upstream/main' into instruction_patch_c… 

    …lean
    @Silvris
    Silvris committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    89799f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. cleanup

    @Silvris
    Silvris committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d8ffad8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into instruction_patch_c… 

    …lean
    @Silvris
    Silvris committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    3d0199b View commit details
    Browse the repository at this point in the history

  3. clean defaults and docstring

    @Silvris
    Silvris committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a89c208 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. define interface that has only the bare minimum required 

    for `Patch.create_rom_file`
    @beauxq
    beauxq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    bed93a0 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge pull request #2 from beauxq/silvris/instruction_patch_clean 

    define interface that has only the bare minimum required
    @Silvris
    Silvris committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d13eb50 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into instruction_patch_clean

    @Silvris
    Silvris committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    385f5f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge branch 'main' into instruction_patch_clean

    @Silvris
    Silvris committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8ce5a64 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. change to dictionary.get

    @Silvris
    Silvris committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4b8f31a View commit details
    Browse the repository at this point in the history

  2. remove unnecessary if statement

    @Silvris
    Silvris committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    debdabe View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Merge branch 'instruction_patch_clean' of https://github.com/Silvris/… 

    …Archipelago into instruction_patch_clean
    @Silvris
    Silvris committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    7cb9385 View commit details
    Browse the repository at this point in the history

  2. update to explicitly check for procedure, restore compatible version … 

    …and manual override
    @Silvris
    Silvris committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    abdb90d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge remote-tracking branch 'upstream/main' into instruction_patch_c… 

    …lean
    @Silvris
    Silvris committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6ddd2e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge remote-tracking branch 'upstream/main' into instruction_patch_c… 

    …lean
    @Silvris
    Silvris committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    27ec372 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into instruction_patch_c… 

    …lean
    @Silvris
    Silvris committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2e55118 View commit details
    Browse the repository at this point in the history

  3. Update Files.py

    @Silvris
    Silvris committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7c97a11 View commit details
    Browse the repository at this point in the history

  4. remove struct uses

    @Silvris
    Silvris committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    4e3f150 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. ensure returning bytes, add token type checking

    @Silvris
    Silvris committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    61a7693 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
    @Silvris @beauxq
    Silvris and beauxq committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    d5216af View commit details
    Browse the repository at this point in the history

  3. pep8

    @Silvris
    Silvris committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    4b64295 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch 'main' into instruction_patch_clean

    @Silvris
    Silvris committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e700ef5 View commit details
    Browse the repository at this point in the history