Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Title with an HTML tags breaks the UI and archive process #330

Closed
neetij opened this issue Mar 18, 2020 · 2 comments
Closed

Bugfix: Title with an HTML tags breaks the UI and archive process #330

neetij opened this issue Mar 18, 2020 · 2 comments
Labels
type: bug report why: security Intended to improve ArchiveBox security or data integrity

Comments

@neetij
Copy link

neetij commented Mar 18, 2020

Describe the bug

Attempting to archive a URL such as https://24ways.org/2019/it-all-starts-with-a-humble-textarea/, that has an HTML tag in the title, results in failure. UI breaks, and PDF was not generated.
Actual title: It All Starts with a Humble <textarea>.

Screenshot_2020-03-18_22-31-41

Software versions

  • OS: Ubuntu 18.04.4 LTS (Xubuntu running under VirtualBox 6.1.4 on Windows 10 Home)
  • ArchiveBox version: [83197ef]
  • Python version: 3.6.9
  • Chrome version: 80.0.3987.87
@pirate pirate added the why: security Intended to improve ArchiveBox security or data integrity label Mar 18, 2020
@pirate
Copy link
Member

pirate commented Mar 18, 2020

related:

@cdvv7788 cdvv7788 mentioned this issue Jul 16, 2020
Merged
6 tasks
pirate added a commit that referenced this issue Jul 16, 2020
@pirate
Merge pull request #365 from cdvv7788/hotfix/#330
58ac44c 
fix: htmlencode titles before rendering the static html index and detail
@cdvv7788
Copy link
Contributor

@neetij this should be solved in the django branch, in case you want to give it a try.

@pirate pirate closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug report why: security Intended to improve ArchiveBox security or data integrity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neetij @pirate @cdvv7788