-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize ludios_wpull #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced namedlist and ordereddefaultdict with stdlib implementations
This was referenced Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the modernization efforts for ludios_wpull to support newer Python versions.
Python Version Change
Python 3.12 was selected due to a potential regression identified in Python 3.11.X
Wpull Version Change
This will raise the version from 3.0.9 to 5.0.0a (4.X.X is skipped per recommendation from @JustAnotherArchivist as my other internal fork of ludios_wpull is using it). The "a" is to denote this is an alpha-release.
Changes
object
and certain collection typesRemaining Broken Unit Tests
These are unit tests that remain broken from the existing ludios_wpull version or will introduced
There are 1 remaining unit test that were broken on Python 3.8 and are still broken on Python 3.12 which is: Fix/remove wpull.proxy.proxy_test.TestProxySSL #8
There's a broken unit test related to how Python 3.11 or Python 3.12 changed socket re-use behavior. This impacts unit test: wpull.network.connection_test.TestConnection.test_sock_reuse
Todo