Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't leak cached authenticated requests #1

Closed
Archomeda opened this issue Jun 13, 2019 · 0 comments
Closed

Don't leak cached authenticated requests #1

Archomeda opened this issue Jun 13, 2019 · 0 comments
Assignees
@Archomeda
Labels
Area: Web cache Related to the web API caching Duration: Short Less than 2 hours of estimated work Priority: High High priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working

Comments

@Archomeda
Copy link
Owner

Currently authenticated requests can be cached when the server responds with an Expires header. This is fine. However, the cache does not differentiate request A with request B if the endpoint is the same, but the used API keys are different. These results need to be cached separately.
@Archomeda Archomeda added Type: Bug Something isn't working Status: Ready Work is accepted and is planned for a future release Priority: High High priority Duration: Short Less than 2 hours of estimated work Area: Web cache Related to the web API caching labels Jun 13, 2019
@Archomeda Archomeda self-assigned this Jun 13, 2019
@Archomeda Archomeda added Status: In progress This is being worked on and removed Status: Ready Work is accepted and is planned for a future release labels Jun 13, 2019
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed Status: In progress This is being worked on labels Jun 13, 2019
Archomeda added a commit that referenced this issue Jun 13, 2019
@Archomeda
Actually use the access token hash for #1, ref fc22b27
1bbdbac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Archomeda Archomeda

Labels
Area: Web cache Related to the web API caching Duration: Short Less than 2 hours of estimated work Priority: High High priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Archomeda