Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make API hostnames configurable #108

Closed
Archomeda opened this issue Nov 14, 2021 · 0 comments · Fixed by #109
Closed

Make API hostnames configurable #108

Archomeda opened this issue Nov 14, 2021 · 0 comments · Fixed by #109
Labels
Area: Render Related to the web render API Area: Web API v2 Related to the v2 web API Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Feature An addition to the project

Comments

@Archomeda
Copy link
Owner

Currently the API hostname is hardcoded to https://api.guildwars2.com/, but having this configurable makes it possible for users to proxy the API. And as an additional feature, it may be possible to catch the render API hostname and replace it as well, but this needs more investigation.
@Archomeda Archomeda added Type: Feature An addition to the project Priority: Medium Medium priority Area: Web API v2 Related to the v2 web API Area: Render Related to the web render API labels Nov 14, 2021
@Archomeda Archomeda mentioned this issue Nov 15, 2021
Merged
@Archomeda Archomeda added the Resolution: Fixed The issue has been fixed label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Render Related to the web render API Area: Web API v2 Related to the v2 web API Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Feature An addition to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement configurable API and render base URLs Archomeda/Gw2Sharp
1 participant
@Archomeda