Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement configurable API and render base URLs #109

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Implement configurable API and render base URLs #109

merged 3 commits into from
Nov 15, 2021

Conversation

Archomeda
Copy link
Owner

This will make the API hostnames configurable through the Connection class. Both the API hostname and the render hostname can be swapped to a custom base URL one.

Closes #108

@Archomeda Archomeda added Type: Feature An addition to the project Area: Web API v2 Related to the v2 web API Area: Render Related to the web render API labels Nov 15, 2021
@Archomeda Archomeda marked this pull request as ready for review November 15, 2021 10:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 15, 2021 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@Archomeda Archomeda merged commit 9993c47 into master Nov 15, 2021
@Archomeda Archomeda deleted the feature/configurable-hostname branch November 15, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Render Related to the web render API Area: Web API v2 Related to the v2 web API Type: Feature An addition to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make API hostnames configurable
1 participant
@Archomeda