Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libNX_X11: -DXTRANS_SEND_FDS=0 is missing #784

Closed
uli42 opened this issue Feb 27, 2019 · 0 comments
Closed

libNX_X11: -DXTRANS_SEND_FDS=0 is missing #784

uli42 opened this issue Feb 27, 2019 · 0 comments

Comments

@uli42
Copy link
Member

uli42 commented Feb 27, 2019

(this is one part of #769, split into a separate issue).

I have compared how libNX_X11 sources are compiled using autotools and how they used to be compiled using Imake. I found `-DXTRANS_SEND_FDS=0 is missing.

Affected files:

ConnDis.c: -DHASXDMAUTH -DSECURE_RPC  -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN    -DFAIL_HARD -DXTRANS_SEND_FDS=0
OpenDis.c:  -DFAIL_HARD -DXTRANS_SEND_FDS=0
XlibInt.c: -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN -DFAIL_HARD -DXTRANS_SEND_FDS=0
x11_trans.c: -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN -DFAIL_HARD -DXTRANS_SEND_FDS=0
xim_trans.c: -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN -DFAIL_HARD -DXTRANS_SEND_FDS=0
imTransR.c -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN -DFAIL_HARD -DXTRANS_SEND_FDS=0
ImTrans.c: -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN  -DFAIL_HARD -DXTRANS_SEND_FDS=0
@uli42 uli42 changed the title libNX_X11: -DXTRDS=0 is missing libNX_X11: -DXTRAND_SEND_FDS=0 is missing Feb 27, 2019
@uli42 uli42 changed the title libNX_X11: -DXTRAND_SEND_FDS=0 is missing libNX_X11: -DXTRANS_SEND_FDS=0 is missing Feb 28, 2019
uli42 added a commit to uli42/nx-libs that referenced this issue Feb 28, 2019
@uli42
libNX_X11: set XTRANS_SEND_FDS=0
eb30832 
NX does not support passing around FDs for local connections.

This will not cause any change in the resulting code as this variable
had been unset by default.

Fixes ArcticaProject#784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uli42