Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproductive category #7364

Open
dustymc opened this issue Feb 1, 2024 · 34 comments
Open

reproductive category #7364

dustymc opened this issue Feb 1, 2024 · 34 comments

Comments

@dustymc
Copy link
Contributor

dustymc commented Feb 1, 2024

Proposal: Instead of creating many very specific code tables, can we have one 'category' code table with...

#6594

vagina perforated
closed unplugged
closed plugged

#6593

nulliparous
primiparous
multiparous
parous

#6408

lactating
not lactating

#6595

nipples enlarged

#6409

pregnant
not pregnant

etc

@ccicero @mkoo @ebraker @Jegelewicz

@campmlc
Copy link

campmlc commented Mar 22, 2024

So this would be "reproductive category" or "reproductive status", and we could include all of the above as controlled vocabulary options, as well as potentially other terms related to other taxa - e.g. birds ("laying"), reptiles (gravid) etc?
@bryansmclean

@dustymc dustymc added this to the Needs Discussion milestone Mar 22, 2024
@bryansmclean
Copy link

bryansmclean commented Mar 25, 2024

Hi all, sorry for delay in responding. From what I can tell, this potential solution leaves off the trait terms, and only preserves their values. The terms are necessary for the community to harvest specific traits for research and biodiversity monitoring. The only way this might work is to prepend values with the trait terms (e.g., lactation::not lactating)

@bryansmclean
Copy link

bryansmclean commented Mar 25, 2024

For example, the recent plan to map testis attributes to more general "gonad" attributes still allows the trait term to be tracked confidently, as long as we can assume that the term "gonad" is a synonym of "testis", which is safe. Does this proposal do that? Im happy to discuss on a call if needed.

@campmlc
Copy link

campmlc commented Mar 25, 2024

Would it be possible to discuss at the next code table meeting next Thursday March 4 at 4pm your time, or perhaps during the prior issues meeting?
@Jegelewicz @ccicero @dustymc

@bryansmclean
Copy link

That first time should work!

@campmlc
Copy link

campmlc commented Mar 25, 2024

Great! The link is on the calendar.

@dustymc
Copy link
Contributor Author

dustymc commented Mar 25, 2024

March 4

I'm not available at that time, but that shouldn't matter.

terms are necessary for the community to harvest specific traits

I don't know what this means; some example data (and questions that might be asked of it) would be really useful.

@bryansmclean
Copy link

Im actually dodging proposals and defenses, and one just got scheduled for this Thursday. I will need to switch to another AWG issues meeting. @campmlc or @Jegelewicz would you pick one and let me know which works best??

@bryansmclean
Copy link

March 4

I'm not available at that time, but that shouldn't matter.

terms are necessary for the community to harvest specific traits

I don't know what this means; some example data (and questions that might be asked of it) would be really useful.

@dustymc I was saying that this proposed change seems to lose the entity itself (for example, "lactation" or "lactation status"). Could become problematic if very standardized values arent used, which we know occurs. For example, when reviewing a repro trait data field, which trait should one match "enlarged" or "descended" or "not" back to? As a data user, I would think one would prefer to retain the specific attribute terms such that this reads, e.g., "nipple enlargement: enlarged", "testes position: descended", or "lactation status: not".

@campmlc
Copy link

campmlc commented Mar 25, 2024

Next week Thursday April 4 at 2pm MDT/4pm EDT is the code table meeting, so that would be the best time to meet. Does that work?
My understanding of this is that there would be one code table with controlled vocabulary - so they would be picked from a standardized drop down. So that could include all the terms below and more. You would be able to search on the reproductive status attribute attribute for any of these terms, and get a download with values in a single column in the attribute download or concatenated as JSON in the main flat search page. It wouldn't overload Arctos with so many attributes causing performance and interface issues- because they will be discoverable from one or a few attributes with a single code table. All of these terms would be parsable and searchable. If I understand correctly, this is similar to the "examined for" and "detected" attributes that share a code table for many different values. @dustymc But let's meet to go over and look at some examples?

#6594

vagina perforated closed unplugged closed plugged

#6593

nulliparous primiparous multiparous parous

#6408

lactating not lactating

#6595

nipples enlarged

#6409

pregnant not pregnant

etc

@bryansmclean
Copy link

Does that work?

Works for me!

@Jegelewicz
Copy link
Member

Jegelewicz commented Apr 4, 2024

One attribute = reproductive description with a code table of possible options

vagina perforated
vagina not perforated
vagina closed
vagina not closed
vagina plugged
vagina not plugged
nulliparous
primiparous
multiparous
parous
lactating no
lactating yes
nipples enlarged
nipples not enlarged
pregnant no
pregnant yes
scrotal
non-scrotal
non-scrotal inguinal
non-scrotal abdominal

@mkoo
Copy link
Member

mkoo commented Apr 4, 2024

@jldunnum @bryansmclean joined the CT committee today-- tentatively agreement on this method but the list needs to be reviewed, edited, confirmed by the RANGES folks before our next meeting. We discussed the pros/cons for this and might be useful to include future UI twaeks for data entry (once this is settled)

@bryansmclean
Copy link

bryansmclean commented Apr 17, 2024

Im trying to re-do a master list of attributes and then the categories of this particular attribute we are discussing on this thread. I think a prefix of some kind would really help within this attribute to organize very different values by general trait type. Did we discuss this and is it possible? Prefixes could follow the, e.g., ranges list of traits but wouldnt have to.

e.g.,
vaginal perforation: perforated
...
parity: parous
...
lactation: no
...
pregnancy: yes
...
testis position: scrotal

@Jegelewicz
Copy link
Member

I was really making an effort to remove punctuation from code table terms. If we do this, we cannot keep trying to do that.

@campmlc
Copy link

campmlc commented Apr 23, 2024

Is there a functional reason for not using punctuation? We already have it in the examined/detected code tables, e.g. "detected" = "virus:Orthohantavirus". If we remove punctuation, how will those code table values be changed?

@bryansmclean
Copy link

I was really making an effort to remove punctuation from code table terms. If we do this, we cannot keep trying to do that.

Is there an alternative way we can make the long list of repro values more "ordered"? Open to suggestions.

@jldunnum
Copy link

jldunnum commented Apr 23, 2024 via email

@bryansmclean
Copy link

Im trying to re-do a master list of attributes and then the categories of this particular attribute we are discussing on this thread. I think a prefix of some kind would really help within this attribute to organize very different values by general trait type. Did we discuss this and is it possible? Prefixes could follow the, e.g., ranges list of traits but wouldnt have to.

e.g., vaginal perforation: perforated ... parity: parous ... lactation: no ... pregnancy: yes ... testis position: scrotal

I would like to get this draft attribute list posted here so that we can all move forward entering/bulkloading traits. Is some kind of prefix or punctuation possible?

@Jegelewicz
Copy link
Member

Jegelewicz commented Apr 25, 2024

Is there a functional reason for not using punctuation?

The use of punctuation can cause issues when transferring data to other formats as the punctuation can signal some sort of break in the data (commas are a particular problem for CSV). From my perspective, it also indicates that our term means more than one thing (not normal). I am by no means an expert, but we just keep doing things and we have yet to develop any rules for code tables - Formatting Rules for CT Terms was started and quickly forgotten as we run around putting out fires and thinking narrowly about the most pressing issue.

Prefixes seem like they belong in code table metadata. To be used internally for sorting and broader searches. The list proposed here sorts together:

lactating no
lactating yes
nipples enlarged
nipples not enlarged
parous
parous multiparous
parous nulliparous
parous primiparous
pregnant no
pregnant yes
testes abdominal
testes inguinal
testes not scrotal
testes scrotal
vagina closed
vagina not closed
vagina not perforated
vagina not plugged
vagina perforated
vagina plugged

@jldunnum
Copy link

Don't think "scrotal abdominal" and "scrotal inguinal" are correct terms

@Jegelewicz
Copy link
Member

Sorry - I am not an expert - just trying to make this work - see new list.

@jldunnum
Copy link

No worries just trying to understand. Why are we using scrotal as the main term as opposed to testes or gonad? Scrotal or abdominal are modifiers of the testes. We use nipples and vagina so seems like we should use testes.

"testes scrotal", testes abdominal, testes inguinal

@campmlc
Copy link

campmlc commented Apr 25, 2024

@Jegelewicz is trying to consolidate all the various issues, which is a bit confusing. Do we have an updated list as requested by RANGES? Is the request for testes scrotal, testes nonscrotal, or for testes abdominal, testes inguinal? Ditto for vagina perforated vs not vs vagina open, vagina closed?
@bryansmclean can you review this list and add/edit as needed so we can all assess?

@Jegelewicz
Copy link
Member

"testes scrotal", testes abdominal, testes inguinal

see new list

@bryansmclean
Copy link

The following brings it more in line with proposed ranges trait terms (which are now prefixes below).
This covers all of the categorial traits we have talked about

lactation no
lactation yes

nipple size enlarged
nipple size not enlarged

parity multiparous
parity nulliparous
parity primiparous
parity parous

pregnancy no
pregnancy yes

testis position non-scrotal
testis position non-scrotal abdominal
testis position non-scrotal inguinal
testis position scrotal

vaginal perforation closed
vaginal perforation not closed
vaginal perforation not plugged
vaginal perforation plugged

@campmlc
Copy link

campmlc commented Apr 26, 2024

@bryansmclean do you really need the " not" values? From a data entry perspective and from UI and download, it seems simpler wording would be much better from a functional perspective. For example, we record "vagina open" and vagina closed" in the field. To do data entry, a student will have to scroll through a drop-down with extra verbiage and confusingly similar terms separated only by a "not". This is a recipe for error. For Arctos data entry and display purposes, could we use the shorter, clearer, simpler two-word terms and put the more complex definition in the documentation?

@bryansmclean
Copy link

Im sure this can be tweaked - which ones are you eyeing as error-prone besides the vaginal perforation values?

@campmlc
Copy link

campmlc commented Apr 26, 2024

Any way to convert all the choices into just two words?
For examples, could the testes position values be simplified?
For example: "testes scrotal, testes non scrotal, testes abdominal, testes inguinal" ?

@campmlc
Copy link

campmlc commented Apr 26, 2024

Nipples enlarged
Nipples small

Vagina open
Vagina closed
Vagina plugged

Lactating yes
Lactating no

Pregnant yes
Pregnant no

Note I changed the initial noun to an adjective, because using the noun is confusing. Does pregnancy test mean right now, or anytime?
Also, how are you defining parity nulliparous vs primiparous etc?
Again, I'm just thinking here about what we displaying via the interface for entry and download.

@campmlc
Copy link

campmlc commented Apr 26, 2024

Darn phone autocorrect: I meant "Pregnancy yes" is confusing relative to "pregnant yes" because the noun has no temporal component.

@jldunnum
Copy link

i think it should be "pregnant yes", referring to the state at time of collection
parity should cover past pregnancies

@dustymc
Copy link
Contributor Author

dustymc commented Apr 26, 2024

referring to the state at time of ...

... attribute determination. Arctos is more than dead rats, this could be used for more than collection, metadata is critical!

Perhaps starting a spreadsheet would facilitate the conversation (and provide an eventual place for definitions)?

@dustymc
Copy link
Contributor Author

dustymc commented May 2, 2024

pregnant yes

Someone remind me why this isn't https://arctos.database.museum/info/ctDocumentation.cfm?table=ctexamined_detected - vague ideas that perhaps we've discussed such things at some point....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants