Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fees to vote modal #116

Merged
merged 5 commits into from
Apr 2, 2024
Merged

feat: add fees to vote modal #116

merged 5 commits into from
Apr 2, 2024

Conversation

patricio0312rev
Copy link
Contributor

[demo] add fees to vote modal

Summary

  • Fee management have been added to vote modal.
image

Checklist

  • I checked the basic interactions between demo and extension, making sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
arkconnect-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 0:54am

@patricio0312rev patricio0312rev mentioned this pull request Apr 1, 2024
Merged
7 tasks
@patricio0312rev
Copy link
Contributor Author

Should be tested with this extension's PR

samharperpittam
samharperpittam requested changes Apr 2, 2024
View reviewed changes
Copy link

@samharperpittam samharperpittam left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patricio0312rev - Is it possible to add a bit more padding between the delegate list and the fee section? Maybe an additional 12-16px . Looks a little cluttered atm.

@samharperpittam samharperpittam marked this pull request as draft April 2, 2024 09:08
@patricio0312rev patricio0312rev marked this pull request as ready for review April 2, 2024 12:53
@ItsANameToo ItsANameToo merged commit aeceec5 into develop Apr 2, 2024
2 checks passed
@ItsANameToo ItsANameToo deleted the feat/fees-to-vote-modal branch April 2, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patricio0312rev @ItsANameToo @samharperpittam