Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fees for vote transaction #204

Merged
merged 6 commits into from
Apr 3, 2024
Merged

feat: fees for vote transaction #204

merged 6 commits into from
Apr 3, 2024

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Apr 1, 2024

[general] allow passing fee for vote transaction

Summary

  • Typing for vote request and response have been updated.
  • Fee can now be passed for vote transactions.
image

Steps to reproduce

  1. Run demo using pnpm dev in feat/fees-to-vote-modal branch from this PR.
  2. Run this branch for extension using pnpm dev or pnpm dev:bare (make sure to have at least 1 address in your wallet).
  3. In demo, connect your wallet.
  4. Click in Vote button.
  5. Select a fee and a candidate.
  6. Wait until the wallet window opens and see the magic ✨

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@goga-m goga-m merged commit 05a4013 into develop Apr 3, 2024
4 checks passed
@goga-m goga-m deleted the feat/voting-custom-fees branch April 3, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants