Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement custom fee for sending action #184

Merged
merged 26 commits into from
Mar 22, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Mar 20, 2024

Summary

Closes: https://app.clickup.com/t/86drqxqyb

Depends on #175

Related PR: ArdentHQ/arkconnect-demo#85

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@shahin-hq shahin-hq changed the base branch from develop to fix/add-tooltip-n-underline-for-trx-screen March 20, 2024 11:06
# Conflicts:
#	src/components/approve/RequestedTransactionBody.tsx
#	src/components/approve/RequestedVoteBody.tsx
#	src/components/approve/TransactionApprovedBody.tsx
#	src/components/approve/VoteApprovedBody.tsx
#	src/components/wallet/address/Address.blocks.tsx
@ItsANameToo ItsANameToo added this to the 1.7.0 milestone Mar 20, 2024
@goga-m
Copy link
Contributor

goga-m commented Mar 21, 2024

@shahin-hq some conflicts on this one

Base automatically changed from fix/add-tooltip-n-underline-for-trx-screen to develop March 21, 2024 10:00
Copy link
Contributor

@patricio0312rev patricio0312rev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@ItsANameToo ItsANameToo merged commit 46c8616 into develop Mar 22, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the feat/implement-custom-fee-for-sending-action branch March 22, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants