Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tooltip and underline for address and amount in action pages #175

Merged
merged 20 commits into from
Mar 21, 2024
Merged

fix: add tooltip and underline for address and amount in action pages #175

merged 20 commits into from
Mar 21, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Mar 18, 2024 •
edited

Summary

Closes: https://app.clickup.com/t/86drwuk4b

Note: Please check it with ledger device as well.

image
image

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@shahin-hq shahin-hq marked this pull request as ready for review March 18, 2024 11:20
@shahin-hq
Copy link
Contributor Author

Waiting #169

@shahin-hq shahin-hq marked this pull request as draft March 18, 2024 12:36
@ItsANameToo ItsANameToo added this to the 1.7.0 milestone Mar 19, 2024
@shahin-hq
Merge branch 'develop' into fix/add-tooltip-n-underline-for-trx-screen
b6d901b 
# Conflicts:
#	src/components/approve/RequestedTransactionBody.tsx
#	src/components/approve/RequestedVoteBody.tsx
#	src/components/approve/TransactionApprovedBody.tsx
#	src/components/approve/VoteApprovedBody.tsx
#	src/components/wallet/address/Address.blocks.tsx
@shahin-hq shahin-hq marked this pull request as ready for review March 20, 2024 11:10
@shahin-hq shahin-hq mentioned this pull request Mar 20, 2024
Merged
7 tasks
shahin-hq and others added 2 commits March 21, 2024 13:27
@shahin-hq
Merge branch 'develop' into fix/add-tooltip-n-underline-for-trx-screen
658c2f5 
# Conflicts:
#	src/components/approve/RequestedTransactionBody.tsx
#	src/components/approve/RequestedVoteBody.tsx
#	src/components/approve/TransactionApprovedBody.tsx
#	src/components/approve/VoteApprovedBody.tsx
@shahin-hq @github-actions
style: resolve style guide violations
4b5fe84
@goga-m goga-m merged commit 2d1df45 into develop Mar 21, 2024
4 checks passed
@goga-m goga-m deleted the fix/add-tooltip-n-underline-for-trx-screen branch March 21, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goga-m goga-m goga-m approved these changes

@patricio0312rev patricio0312rev patricio0312rev approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shahin-hq @goga-m @patricio0312rev @ItsANameToo @alfonsobries