test: fix timeout errors in wallet details tests #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
goga-m
requested review from
ItsANameToo,
samharperpittam,
dated,
boldninja and
alexbarnsley
as code owners
ItsANameToo
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small improvement on the wallet detail test to ignore unesserary awaits for wallets top section components (vote info) and only wait for transaction table to render in order to open the detail modal, as this is the goal of this test.
The timeouts are provably caused by multi re-renders of the child components of wallet details page (transactions table, wallet vote section) in combination with the modal opening and closing that are not performant and are causing delays. With this change we improve the time for assertion to compete with less awaits.
Checklist