Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve checks for ledger compatibility #381

Merged
merged 17 commits into from
Mar 1, 2023
Merged

refactor: improve checks for ledger compatibility #381

merged 17 commits into from
Mar 1, 2023

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Feb 22, 2023 •
edited

Summary

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel
Copy link

vercel bot commented Feb 22, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
arkvault ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 2:10PM (UTC)

@goga-m goga-m force-pushed the refactor/ledger-compatibility branch from e6cca9d to 6879985 Compare February 23, 2023 13:32
@goga-m goga-m force-pushed the refactor/ledger-compatibility branch from 91a55d8 to 2b98378 Compare February 23, 2023 13:58
@goga-m goga-m force-pushed the refactor/ledger-compatibility branch from ba1d552 to 6cfb55b Compare February 26, 2023 16:47
@goga-m goga-m marked this pull request as ready for review February 26, 2023 16:48
@goga-m goga-m force-pushed the refactor/ledger-compatibility branch from 6cfb55b to 708b28e Compare February 26, 2023 16:49
@samharperpittam
Copy link

Task Linked: https://app.clickup.com/t/862jaatu1

@ItsANameToo ItsANameToo merged commit f8ab0c9 into develop Mar 1, 2023
@ItsANameToo ItsANameToo deleted the refactor/ledger-compatibility branch March 1, 2023 08:06
ItsANameToo pushed a commit that referenced this pull request Apr 17, 2023
@goga-m @ItsANameToo
refactor: improve checks for ledger compatibility (#381)
8b88d84
ItsANameToo pushed a commit that referenced this pull request Apr 17, 2023
@goga-m @ItsANameToo
refactor: improve checks for ledger compatibility (#381)
0be9feb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

@dated dated Awaiting requested review from dated

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goga-m @samharperpittam @ItsANameToo