Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: buttons on error step #467

Merged
merged 17 commits into from
Apr 24, 2024
Merged

refactor: buttons on error step #467

merged 17 commits into from
Apr 24, 2024

Conversation

alfonsobries
Copy link
Contributor

Summary

Closes https://app.clickup.com/t/86dt8x80y

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Apr 23, 2024 1:14pm

@ItsANameToo ItsANameToo marked this pull request as draft April 18, 2024 07:52
@ItsANameToo ItsANameToo added this to the 1.15.0 milestone Apr 18, 2024
@ItsANameToo
Copy link
Contributor

@alfonsobries please have a look at the failing workflows

@alfonsobries alfonsobries marked this pull request as ready for review April 19, 2024 17:17
@ItsANameToo ItsANameToo merged commit cd5f26e into develop Apr 24, 2024
29 checks passed
@ItsANameToo ItsANameToo deleted the refactor/error-page-buttons branch April 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

@shahin-hq shahin-hq shahin-hq approved these changes

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alfonsobries @ItsANameToo @samharperpittam @shahin-hq