Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support beta builds #54

Closed
rmackay9 opened this issue Jun 12, 2023 · 8 comments
Closed

Support beta builds #54

rmackay9 opened this issue Jun 12, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@rmackay9
Copy link

rmackay9 commented Jun 12, 2023

Currently users can select between Stable and Latest. It would be nice if during beta testing periods users could also select Beta.

This request comes from this discussion.

@Ryanf55
Copy link
Contributor

Ryanf55 commented Nov 25, 2023

Or better yet, allow a user to input an arbitrary repo URL and branch/tag/hash.

The use case is having someone flight-test a PR before it gets merged without requiring someone to manually compile the build.

What do you think about changing the dropdown to allow a manual text field like so:
https://stackoverflow.com/questions/5650457/html-select-form-with-option-to-enter-custom-value

The difference is explained here:
https://www.geeksforgeeks.org/difference-between-datalist-select-tags-in-html/

The only challenge I see is setting a default, however this solution seems to work great:
https://stackoverflow.com/a/51325565/11032285

@khancyr
Copy link
Contributor

khancyr commented Nov 25, 2023

We cannot do open access as that would the open door to abuse and we cannot scale the demand.

If someone have custom code, they should be able to compile it. We can do a need on demand workflow on GitHub action for this and let the person making the request to us its infrastructure

@Ryanf55
Copy link
Contributor

Ryanf55 commented Nov 25, 2023

What about any branch/tag in the upstream team repo? Only maintainers can push branches.

From earlier discussions, it sounds like we need a way for the custom build server to automatically pick up new betas.

@MichelleRos
Copy link
Contributor

I quite like the idea of just listing the repos and letting people build any branch from those. Then we could add a few devs' repos, which would allow them to more easily get people to test their code (instead of them having to manually build firmware for each person testing).
Something like a dropdown for the repo and then a text field for the branch?
This would still avoid opening any paths to abuse since people can't build any random code.
Would still be good to make the main Stable & Latest branches easy to find though. Not too sure what would be the best UI for that, though.

@Ryanf55
Copy link
Contributor

Ryanf55 commented Nov 26, 2023

I quite like the idea of just listing the repos and letting people build any branch from those. Then we could add a few devs' repos, which would allow them to more easily get people to test their code (instead of them having to manually build firmware for each person testing). Something like a dropdown for the repo and then a text field for the branch? This would still avoid opening any paths to abuse since people can't build any random code. Would still be good to make the main Stable & Latest branches easy to find though. Not too sure what would be the best UI for that, though.

Yea, I had thought of the same thing. Some options include an advanced mode, ordering the options, styling the "recommended" ones differently. That said, the original requests here and in some of the other tickets are specifically at getting branches only on ardupilot/ardupilot.

@DavideLentini
Copy link

Hi all , would it be possible to compile a custom build for 4.5.0-beta2 in an alternative method ?Since on the Custom Build Server website it is not possible to compile firmware for beta branches ?

@rmackay9
Copy link
Author

rmackay9 commented Mar 1, 2024

Hi @DavideLentini,

The only other way would be to setup a build environment and then build from the Copter-4.5 branch.

@rmackay9
Copy link
Author

beta builds are apparently now supported!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants