GCSVews: Configuration: Compass2: support new compass param names #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build MissionPlanner 1.0.3099 completed (commit 073e8bae90 by @IamPete1) |
meee1
reviewed
Nov 18, 2021
| mavlinkCheckBoxUseCompass1.setup(1, 0, "COMPASS_USE", MainV2.comPort.MAV.param); | ||
| mavlinkCheckBoxUseCompass2.setup(1, 0, "COMPASS_USE2", MainV2.comPort.MAV.param); | ||
| mavlinkCheckBoxUseCompass3.setup(1, 0, "COMPASS_USE3", MainV2.comPort.MAV.param); | ||
| mavlinkCheckBoxUseCompass1.setup(1, 0, get_compass_param_name("USE", 1), MainV2.comPort.MAV.param); |
There was a problem hiding this comment.
there is 2 options here, use what you have done, or pass in both text versions, as the param name field can take an array (havn't checked this, but could be added, as param renames are common these days)
IamPete1
force-pushed
the
compass_param_name
branch
from
0fe8296
to
d6275bf
Compare
|
@meee1 your right the array of names method is way better, I have changed to that. I had to add a new method to the param list, but it seems to work as expected. |
|
nice, i like the approach |
|
✅ Build MissionPlanner 1.0.3100 completed (commit 6cceca87c1 by @IamPete1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first go a
C#, so apologies if this is a bit of a mess.This adds support for the new compass params names proposed in ArduPilot/ardupilot#19123 and allows both new and old to work as before.