Reboot: auto reconnect #2967
Merged
Reboot: auto reconnect #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
commented
Oct 8, 2022
| if (!bootloadermode && (BaseStream is SerialPort)) | ||
| { | ||
| // Direct USB will disconnect after a reboot, wait and see if we should re-connect | ||
| Thread.Sleep(500); |
There was a problem hiding this comment.
This timeout seems to work, its bit of a guess, not sure if it would work in every case, maybe there is a better way?
IamPete1
commented
Oct 8, 2022
| if (!BaseStream.IsOpen) | ||
| { | ||
| Open(true); | ||
| } |
There was a problem hiding this comment.
We could auto refresh params if the link still open. That would be the right thing in most cases but quite annoying on a very slow link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This auto reconnects after a sending a reboot command, useful when doing initial setup where lots of reboots are needed. Also handy for catching very early start up messages.
Testing: