Small fixes: remove unused headers, fix comment, more #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clydemcqueen
commented
Mar 28, 2022
•
clydemcqueen
commented
- Review unused headers
- Fix comment re: Ignition Gazebo frame conventions
- Use local imuMsg
|
@srmainwaring Please take a look Edit: ah, now I see the 3rd commit. I just cherry-picked it. |
clydemcqueen
changed the title
srmainwaring
added
bug
srmainwaring
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Thanks @clydemcqueen, LGMT
I think we may need to review the value used in the example SDF for transform from the Gazebo ENU frame to ArduPilot NED as I suspect it's missing a rotation about Z by PI/2. That's for a follow up PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.