Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1 log format changed #2

Closed
EosBandi opened this issue Jul 24, 2021 · 6 comments · Fixed by #3
Closed

4.1 log format changed #2

EosBandi opened this issue Jul 24, 2021 · 6 comments · Fixed by #3

Comments

@EosBandi
Copy link

Log messages not contains Instance field and store data from multiple instances in the same message id.
For example XKF1 now contains log from all EKF lanes...

@khancyr
Copy link
Collaborator

khancyr commented Jul 26, 2021

Hello,
I will look at that but normally the parsing is done with the information from the message type itself, so if the definition is done correctly the parsing should be correct too.

@Georacer
Copy link

It's not an issue on the parser itself. But recently the following messages have added an "instance" field that refers to different instances/core relaying the same fields but referring to different variables. But since they all write to the same topic the automated decoder dumps them all in the same topic, making it hard to visualize and use.

Here's what I did for the issue in Ardupilog: Georacer/ardupilog@46e1584

@EosBandi
Copy link
Author

Indeed, but even ardupilog is outdated at the moment, since now IMU, MAG, GPS and other sensor messages are having instance field as well. (Make it worst, the field name is not C but with sensors)

@EosBandi
Copy link
Author

EosBandi commented Jul 26, 2021

From UAVLogViewer, it seems that a '#' unit type indicates instance, so you can automate detecting "instanced" messages....
https://github.com/ArduPilot/UAVLogViewer/blob/d09775cfc392b285d1244e2c8e16f935c194f2f6/src/tools/parsers/dataflashParser.js#L142
But have to process FMTU messages as well.

@Georacer
Copy link

Indeed, but even ardupilog is outdated at the moment, since now IMU, MAG, GPS and other sensor messages are having instance field as well. (Make it worst, the field name is not C but with sensors)

There was a feature branch that addressed this, I just merged it to master.

@Georacer
Copy link

From UAVLogViewer, it seems that a '#' unit type indicates instance, so you can automate detecting "instanced" messages....
https://github.com/ArduPilot/UAVLogViewer/blob/d09775cfc392b285d1244e2c8e16f935c194f2f6/src/tools/parsers/dataflashParser.js#L142
But have to process FMTU messages as well.

I didn't know this. Good info, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants