Added support for units, multipliers and instances #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a huge overhaul of the plotjuggler-apbin-plugin with many code changes! plotjuggler-apbin-plugin now reads and uses - units (FMTU and UNIT messages) - multipliers (FMTU and MULT messages) and applies them correctly to the message data. The plugin handles instances defined by the unit character '#'. Instances are now displayed correctly in PlotJuggler. The plugin tries to convert the time base to unix time (based on the logged data from GNSS). This is useful if you want to analyze rosbags and ArduPilot logfiles in parallel.
|
Hello Pierre, Jonas worked with us while developing this PR. We tested it in real world log files together with ROS bags and it works great. |
|
That is awesome! I never had time to look on this. |
|
Please merge this in. It has been waiting for 1,5 years. |
|
@khancyr any progress on this? |
|
I just compiled this one and it works a treat! Thanks! It's so nice to finally be able to use PlotJuggler for Ardupilot again. |
|
Thanks Pierre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge overhaul of the plotjuggler-apbin-plugin with many code changes!
Plotjuggler-apbin-plugin now reads and uses
and applies them to the message data.
The plugin handles instances defined by the unit character '#'. Instances are now displayed correctly in PlotJuggler (fixes #2).
The plugin tries to convert the time base to unix time (based on the logged data from GNSS). This is useful if you want to analyze rosbags and ArduPilot logfiles in parallel.
This pull request also includes the changes in #1 (closes #1).