New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly validate maxInclusive datatypes #1186
Merged
stevenbronson-wk
merged 1 commit into
Arelle:master
from
austinmatherne-wk:xml-schema-datatype-validation
Apr 29, 2024
Merged
Correctly validate maxInclusive datatypes #1186
stevenbronson-wk
merged 1 commit into
Arelle:master
from
austinmatherne-wk:xml-schema-datatype-validation
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max values used for `byte`, `unsignedByte`, `short`, `unsignedShort` types were all one too low. The schema restrictions for these datatypes are maxInclusive.
austinmatherne-wk
temporarily deployed
to
integration-tests
April 29, 2024 23:07
— with
GitHub Actions
Inactive
austinmatherne-wk
temporarily deployed
to
integration-tests
April 29, 2024 23:07
— with
GitHub Actions
Inactive
austinmatherne-wk
temporarily deployed
to
integration-tests
April 29, 2024 23:07
— with
GitHub Actions
Inactive
austinmatherne-wk
temporarily deployed
to
integration-tests
April 29, 2024 23:08
— with
GitHub Actions
Inactive
austinmatherne-wk
temporarily deployed
to
integration-tests
April 29, 2024 23:08
— with
GitHub Actions
Inactive
austinmatherne-wk
temporarily deployed
to
integration-tests
April 29, 2024 23:08
— with
GitHub Actions
Inactive
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaroncameron-wk
approved these changes
Apr 29, 2024
stevenbronson-wk
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this fixes #929.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
The max values used for
byte
,unsignedByte
,short
,unsignedShort
datatypes were all one too low. The facets for these datatypes are maxInclusive not maxExclusive.byte
unsignedByte
short
unsignedShort
Description of change
Use maxInclusive checks for
byte
,unsignedByte
,short
, andunsignedShort
.Steps to Test
CI
review:
@Arelle/arelle