Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Updater module #308

Conversation

austinmatherne-wk
Copy link
Contributor

@austinmatherne-wk austinmatherne-wk commented Aug 31, 2022

Reason for change

#247

Description of change

  • For the Updater module:
    • Makes it work again on mac and windows
    • Adds warning messages when something goes wrong
    • Adds type hints
    • Adds test coverage

Steps to Test

  • load the GUI (python arelleGUI.pyw)
  • use the check for updates feature in the help menu
  • experiment with changing the date in arelle/Version.version to be:
    • older than the latest update
    • newer than the latest update
    • the same as the latest update

review:
@Arelle/arelle @codebykevin

@austinmatherne-wk austinmatherne-wk changed the title Fix long Updater module Fix Updater module Aug 31, 2022
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:30 Inactive
@austinmatherne-wk austinmatherne-wk linked an issue Aug 31, 2022 that may be closed by this pull request
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@austinmatherne-wk austinmatherne-wk temporarily deployed to integration-tests August 31, 2022 13:38 Inactive
@stevenbronson-wk
Copy link
Contributor

Tested on OS X. The updater offers and successfully downloads newer versions, notifies if the current version is newer than the download version, and notifies if the current version is the same as the download version. It warns if it can't connect to the update server.

@stevenbronson-wk stevenbronson-wk merged commit d9fe631 into Arelle:master Sep 1, 2022
@austinmatherne-wk austinmatherne-wk deleted the 247-arellegui-fails-to-download-update branch September 1, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arelleGUI fails to download update
4 participants