New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Updater module #308
Merged
stevenbronson-wk
merged 17 commits into
Arelle:master
from
austinmatherne-wk:247-arellegui-fails-to-download-update
Sep 1, 2022
Merged
Fix Updater module #308
stevenbronson-wk
merged 17 commits into
Arelle:master
from
austinmatherne-wk:247-arellegui-fails-to-download-update
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Displays info dialog if platform not supported by updater or offline mode is enabled.
This is technically an API breaking change, but updater was previously broken.
linux doesn't have an update URL and isn't supported by the updater.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaroncameron-wk
approved these changes
Aug 31, 2022
stevenbronson-wk
approved these changes
Aug 31, 2022
Tested on OS X. The updater offers and successfully downloads newer versions, notifies if the current version is newer than the download version, and notifies if the current version is the same as the download version. It warns if it can't connect to the update server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
#247
Description of change
Steps to Test
python arelleGUI.pyw
)arelle/Version.version
to be:review:
@Arelle/arelle @codebykevin