Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MvpAppCompatDialogFragment to moxy-androidx #244

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
package com.arellomobile.mvp;

import android.os.Bundle;
import androidx.fragment.app.Fragment;
import androidx.appcompat.app.AppCompatDialogFragment;

/**
* Date: 25-Fed-18
* Time: 11:50
*
* @author Roman Savelev
*/
@SuppressWarnings({"ConstantConditions", "unused"})
public class MvpAppCompatDialogFragment extends AppCompatDialogFragment {

private boolean mIsStateSaved;
private MvpDelegate<? extends MvpAppCompatDialogFragment> mMvpDelegate;

public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);

getMvpDelegate().onCreate(savedInstanceState);
}

public void onResume() {
super.onResume();

mIsStateSaved = false;

getMvpDelegate().onAttach();
}

public void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState);

mIsStateSaved = true;

getMvpDelegate().onSaveInstanceState(outState);
getMvpDelegate().onDetach();
}

@Override
public void onStop() {
super.onStop();

getMvpDelegate().onDetach();
}

@Override
public void onDestroyView() {
super.onDestroyView();

getMvpDelegate().onDetach();
getMvpDelegate().onDestroyView();
}

@Override
public void onDestroy() {
super.onDestroy();

//We leave the screen and respectively all fragments will be destroyed
if (getActivity().isFinishing()) {
getMvpDelegate().onDestroy();
return;
}

// When we rotate device isRemoving() return true for fragment placed in backstack
// http://stackoverflow.com/questions/34649126/fragment-back-stack-and-isremoving
if (mIsStateSaved) {
mIsStateSaved = false;
return;
}

// See https://github.com/Arello-Mobile/Moxy/issues/24
boolean anyParentIsRemoving = false;
Fragment parent = getParentFragment();
while (!anyParentIsRemoving && parent != null) {
anyParentIsRemoving = parent.isRemoving();
parent = parent.getParentFragment();
}

if (isRemoving() || anyParentIsRemoving) {
getMvpDelegate().onDestroy();
}
}

/**
* @return The {@link MvpDelegate} being used by this Fragment.
*/
public MvpDelegate getMvpDelegate() {
if (mMvpDelegate == null) {
mMvpDelegate = new MvpDelegate<>(this);
}

return mMvpDelegate;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package androidx.appcompat.app;


import androidx.fragment.app.DialogFragment;

/**
* Date: 25-Fed-18
* Time: 11:50
*
* @author Roman Savelev
*/
public class AppCompatDialogFragment extends DialogFragment
{

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package androidx.fragment.app;

/**
* Date: 25-Fed-18
* Time: 11:50
*
* @author Roman Savelev
*/
public class DialogFragment extends Fragment {

}