update to v4 of gitlab api #80

ilushka85 · 2018-06-08T02:43:29Z

No description provided.

…utside of gitlab-plugin as it is wrong there. Also add support for reopen action to do same as Open.

…ong variable

ghost · 2018-06-08T13:49:42Z

I have this stackstrace if I launch a scan of my gitlab projects :

[Fri Jun 08 13:43:45 UTC 2018] Updating actions...
[Fri Jun 08 13:43:45 UTC 2018] Consulting GitLab Projects
ERROR: [Fri Jun 08 13:43:45 UTC 2018] Could not fetch sources from navigator argelbargel.jenkins.plugins.gitlab_branch_source.GitLabSCMNavigator@49df211a
java.util.NoSuchElementException: unknown id: visible
	at argelbargel.jenkins.plugins.gitlab_branch_source.api.GitLabProjectSelector.byId(GitLabProjectSelector.java:19)
	at argelbargel.jenkins.plugins.gitlab_branch_source.ProjectQuery.<init>(ProjectQuery.java:31)
	at argelbargel.jenkins.plugins.gitlab_branch_source.GroupProjectQuery.<init>(GroupProjectQuery.java:15)
	at argelbargel.jenkins.plugins.gitlab_branch_source.ProjectQuery.create(ProjectQuery.java:20)
	at argelbargel.jenkins.plugins.gitlab_branch_source.SourceVisitor.visitSources(SourceVisitor.java:25)
	at argelbargel.jenkins.plugins.gitlab_branch_source.GitLabSCMNavigator.visitSources(GitLabSCMNavigator.java:133)
	at jenkins.branch.OrganizationFolder.computeChildren(OrganizationFolder.java:458)
	at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.updateChildren(ComputedFolder.java:276)
	at com.cloudbees.hudson.plugins.folder.computed.FolderComputation.run(FolderComputation.java:165)
	at jenkins.branch.OrganizationFolder$OrganizationScan.run(OrganizationFolder.java:910)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)

tnijboer · 2018-06-27T09:30:44Z

@jbomaileva we have the same issue.

alexkoepke · 2018-06-27T13:06:00Z

Any updates or progress on this? How could one help move this along? I believe this could resolve #83.

awilhelmer · 2018-06-29T14:39:48Z

GitLab v11 removed the v3 API. I tried your PR, seems to be working only when i remove my old project (old settings on version 0.6.x of this plugin)
After recreating, the Jenkins project scan is working and all pipelines are created. But the webhooks arent registered in gitlab. Triggering the web hooks from old projects arent working too. However, testing the webhook from Gitlab returns HTTP 200, loggings are fine, but no builds are started.

Saving configuration triggers system webhook register which results in 403 forbidden responses

awilhelmer · 2018-07-04T08:08:09Z

src/main/java/argelbargel/jenkins/plugins/gitlab_branch_source/heads/GitLabSCMHead.java

@@ -14,11 +14,11 @@
    public static final String REVISION_HEAD = "HEAD";

    public static GitLabSCMBranchHead createBranch(int projectId, String name, String hash) {
-        return createBranch(projectId, name, hash, false);
+        return createBranch(projectId, name+"t2", hash, false);


This causes problems if you change the name ...

awilhelmer · 2018-07-04T08:14:00Z

Okay found all problems and it's working now.

Add org.gitlab.api.models.GitlabProject in ClassFilter
In GitLabSCMHead.java remove the suffix "t2" and "t3" ...

Last problem is registering System WebHook in GitlabAPI. Method private GitlabSystemHook registerSystemHook(String url) throws IOException. It always throws WARNING: could not register hook https://***/gitlab-scm/notify/***: error accessing gitlab-api: {"message":"403 Forbidden"}, don't know why, i created this hook manually in gitlab via curl ...

curl --request POST --header "PRIVATE-TOKEN: ***" "https://***/api/v4/hooks?url=https://***/gitlab-scm/notify/***&enable_ssl_verification=false"

alexkoepke · 2018-07-06T13:17:27Z

Hey @awilhelmer,

Thanks for looking into this! When you said, "Okay found all problems and it's working now." Were you referring to this pull request?

Also, when you said, "Last problem is registering System WebHook in GitlabAPI." Is that a new issue or did you resolve it?

Sorry for the confusion.

Cheers,
Alex

awilhelmer · 2018-07-06T13:54:34Z

Hi @alexkoepke
yes iam referring to this pull request and the two changes i made (The two points) locally. The System Webhook is still a problem and i think it's a problem in the Gitlab API v4 dependency...

ghost · 2018-07-06T14:03:21Z

So, the plugin is not fully compatible with gitlab 11 yet ?

awilhelmer · 2018-07-08T10:42:49Z

It works. The System Webhook is to detect new or deleted branches. The Push webhook for projects works fine.

tnijboer · 2018-07-09T06:39:43Z

can you share your commits?

# Conflicts: # pom.xml # src/main/java/argelbargel/jenkins/plugins/gitlab_branch_source/SourceHeads.java # src/main/java/argelbargel/jenkins/plugins/gitlab_branch_source/actions/GitLabSCMPublishAction.java # src/main/java/argelbargel/jenkins/plugins/gitlab_branch_source/hooks/HookHandler.java

ilushka85 · 2018-07-11T18:15:12Z

I resolved the issues noted in code that were part of my code for testing and also merged in the latest changed from master on here.

Additionally I began work on getting the note event trigger which is successfully working for merge requests but I cannot get it to trigger a job because it determines that the source code has not chnaged and will not trigger a build.

I would appreciate some help on this.

paulerickson · 2018-07-30T18:37:37Z

Thanks for working on this, @ilushka85! Commenting out the note event stuff, I was able to build this (findbugs complained about the unused assignment) and get it working again after a Gitlab upgrade

alexkoepke · 2018-08-13T13:26:13Z

@paulerickson do you think your fixes will get this PR to a passing state? @Argelbargel are you able to confirm?

paulerickson · 2018-08-13T16:32:24Z

@alexkoepke okay, I opened #91 with Ilya's changes minus Notes, although I have not tested just yet. It would be great if someone else could test it too.

Push events still don't trigger for me, which I think is existing since 0.6.6.7

paulerickson · 2019-02-11T17:53:25Z

I think this can be closed, since the v4 changes were incorporated in #91

alexkoepke · 2019-02-11T17:59:36Z

@paulerickson fantastic! Good to hear, I’ll test when I get the chance.

Ilya Beyrak added 7 commits April 16, 2018 08:59

add membership=true to gitlab project listings

2dbcb56

add removal of double slashes which occurs and makes api fail

a8a2aa6

decode MergeRequestHook objectAttributes action as string and do it o…

2d85b29

…utside of gitlab-plugin as it is wrong there. Also add support for reopen action to do same as Open.

fix settings screen not storing option for Build Merged because of wr…

b93258e

…ong variable

remove duplicative call to build after merge

062ef0c

fix test code

86b092e

update to gitlab v4 api

59444ff

updates based on v4 api and publishing failed stage when unstable build

f47ec80

awilhelmer reviewed Jul 4, 2018

View reviewed changes

Ilya Beyrak added 2 commits July 11, 2018 13:04

fix issues and add prelim support for handling note events

289aa6d

missed comimt

4f90d3a

paulerickson mentioned this pull request Aug 13, 2018

Migrate to v4 API #91

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update to v4 of gitlab api #80

update to v4 of gitlab api #80

ilushka85 commented Jun 8, 2018

ghost commented Jun 8, 2018

tnijboer commented Jun 27, 2018

alexkoepke commented Jun 27, 2018

awilhelmer commented Jun 29, 2018 •

edited

Loading

awilhelmer Jul 4, 2018 •

edited

Loading

awilhelmer commented Jul 4, 2018

alexkoepke commented Jul 6, 2018

awilhelmer commented Jul 6, 2018

ghost commented Jul 6, 2018

awilhelmer commented Jul 8, 2018

tnijboer commented Jul 9, 2018

ilushka85 commented Jul 11, 2018

paulerickson commented Jul 30, 2018

alexkoepke commented Aug 13, 2018

paulerickson commented Aug 13, 2018

paulerickson commented Feb 11, 2019

alexkoepke commented Feb 11, 2019

update to v4 of gitlab api #80

Are you sure you want to change the base?

update to v4 of gitlab api #80

Conversation

ilushka85 commented Jun 8, 2018

ghost commented Jun 8, 2018

tnijboer commented Jun 27, 2018

alexkoepke commented Jun 27, 2018

awilhelmer commented Jun 29, 2018 • edited Loading

awilhelmer Jul 4, 2018 • edited Loading

Choose a reason for hiding this comment

awilhelmer commented Jul 4, 2018

alexkoepke commented Jul 6, 2018

awilhelmer commented Jul 6, 2018

ghost commented Jul 6, 2018

awilhelmer commented Jul 8, 2018

tnijboer commented Jul 9, 2018

ilushka85 commented Jul 11, 2018

paulerickson commented Jul 30, 2018

alexkoepke commented Aug 13, 2018

paulerickson commented Aug 13, 2018

paulerickson commented Feb 11, 2019

alexkoepke commented Feb 11, 2019

awilhelmer commented Jun 29, 2018 •

edited

Loading

awilhelmer Jul 4, 2018 •

edited

Loading