handle situation where wireguard netlink returns invalid data #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip duplicate key rather than raise assertion
liske
reviewed
Jan 3, 2024
| @@ -27,7 +27,10 @@ def __init__(self, peer, spill_preshared_keys=False): | |||
| self.endpoint = peer.get_attr('WGPEER_A_ENDPOINT') | |||
| self.persistent_keepalive_interval = peer.get_attr('WGPEER_A_PERSISTENT_KEEPALIVE_INTERVAL') | |||
| self.last_handshake_time = peer.get_attr('WGPEER_A_LAST_HANDSHAKE_TIME') | |||
| if not self.last_handshake_time > 0: | |||
| try: | |||
| if not self.last_handshake_time > 0: | |||
There was a problem hiding this comment.
Instead of a try+except, you could also check if whether the variable has a None value:
if self.last_handshake_time is None or not self.last_handshake_time > 0:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally encounter that wg interface returns invalid data.
Either returns NULL in last handshake or returns a peer twice.
This short patch handles these situations.