Feature Failover sink #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add failure sink to log events while RabbitMQ is unavailable - Removed AmqpUri support - Refactored the Configuration extensions - Add console app samples projects - replaced hostname config with hostnames - upgrade codecov task to v4
Add readme file as package readme
|
@sungam3r could you take a look at this PR? |
Add more tests for Configuration Extensions
Merged
sungam3r
reviewed
Feb 5, 2024
| @@ -1,3 +1,7 @@ | |||
| # https://docs.codecov.com/docs/codecov-yaml | |||
|
|
|||
| ignore: | |||
There was a problem hiding this comment.
it should be done at coverlet level via exclude filters
sungam3r
reviewed
Feb 5, 2024
sungam3r
reviewed
Feb 5, 2024
sungam3r
reviewed
Feb 5, 2024
sungam3r
reviewed
Feb 5, 2024
src/Serilog.Sinks.RabbitMQ/Sinks/RabbitMQ/EmitEventFailureHandling.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 5, 2024
src/Serilog.Sinks.RabbitMQ/Sinks/RabbitMQ/EmitEventFailureHandling.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 5, 2024
sungam3r
reviewed
Feb 5, 2024
src/Serilog.Sinks.RabbitMQ/Sinks/RabbitMQ/RabbitMQConnectionFactory.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 5, 2024
src/Serilog.Sinks.RabbitMQ/Sinks/RabbitMQ/RabbitMQSinkConfiguration.cs
Outdated
Show resolved
Hide resolved
sungam3r
approved these changes
Feb 5, 2024
|
I looked briefly all the changes. |
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ling.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ling.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ation.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
… tests Removed HostNames count in RabbitMQConnectionFactory. There's always 1 host name
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
===========================================
+ Coverage 81.86% 96.53% +14.66%
===========================================
Files 9 8 -1
Lines 353 346 -7
Branches 64 41 -23
===========================================
+ Hits 289 334 +45
+ Misses 34 5 -29
+ Partials 30 7 -23 ☔ View full report in Codecov by Sentry. |
avermunt
approved these changes
Feb 6, 2024
This was referenced Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133