Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!] GENERAL discussion, feedback, questions belong here! (v9) #241

Closed
Aris-t2 opened this issue Oct 25, 2019 · 316 comments
Closed

[!] GENERAL discussion, feedback, questions belong here! (v9) #241

Aris-t2 opened this issue Oct 25, 2019 · 316 comments

Comments

@Aris-t2
Copy link
Owner

Aris-t2 commented Oct 25, 2019

Make sure you have updated your configuration to the most recent version of this projects files and are using the latest version of the "options" required by your Firefox version >before< reporting problems!

Continued from #3, #41, #88, #109, #133, #163, #189 and #211.

Instead of opening new "issues" for general talk we can use this area for discussions, feedback and questions. Open new "issues" for real bugs and problems.

Custom JS scripts to restore more classic features
https://github.com/Aris-t2/CustomJSforFx

Things this project will not target/recreate

  • a CTR like plugin/application to generate ready-to-use CSS
  • curved tabs (thanks those are finally gone!)
  • old complete themes

Things not possible with CSS

  • more toolbars like add-on/status bar (CSS can not create new toolbars)
    • displaying full sized status popup below window content is possible
    • bookmarks toolbar at windows bottom is possible (simulated addon-bar)
  • new buttons (CSS can not create new buttons)
  • additional menuitems (CSS can not create new items)
  • custom/new/different functions for buttons/menuitems/menus
  • activity indicator (see 'custom JS scripts')
  • preference/options window
  • additional location bar
  • favicon in location bars identity box (see 'custom JS scripts')
  • moving menubar items to a different toolbar
  • restart button (see 'custom JS scripts')
  • ... many more
@m4n8tpr4
Copy link

m4n8tpr4 commented Oct 25, 2019

First time commenter, bear with me.

With Fx70, the font size of URLs in the locationbar autocomplete popup got smaller. How can I change it? I tried both the ac_popup_classic_with_url_only_fx68.css and ac_popup_url_and_title_50percent_width.css options.
kép

In addition, in the ac_popup_url_and_title_50percent_width.css option, the search engine button line at the bottom of the popup is apparently sized at 50% width (extending from 25% to 75%), with a line break.
kép

Are any of these two bugs worth reporting, or did I just miss some setting possibility?

@Infernoflower
Copy link

How do I set the config to default? And I applied the red colour to the toolbar and header via the Windows personalization colour settings. Should I set the window colour back to its default value in Settings?

@ImSpecial
Copy link

Hey Aris, is there a way to have this dark blue highlight color that happens when you type, be of a different color, preferably light grey or light blue, like what my green arrow points to.

https://i.imgur.com/1t0DUVo.png

@bendover22
Copy link

In web developer tools (Ctrl + Shift + I), that is - NOT for Browser Toolbox, in Firefox quantum is it possible to permanently change font size, name (e.g., Liberation mono), font weight without massive effort?

I was able to change font size, weight, etc., in some modules of browser toolbox using fairly simple CSS (from Mozilla support site).
They said CSS changes for browser toolbox had to go in the profile, under a created directory, "chrome_debugger_profile/chrome/userChrome.css".

But nothing I've read or tried says it's as easy to change these things in web developer tools. CSS for it goes in the usual path for userChrome.css.
At least, not easy to change fonts in all the modules (Inspector, Debugger, DOM, etc.
Many commented they just used Ctrl and '+' key to increase font size in web devtools. Doing that every time gets annoying & after every restart.

Ctrl and + increases the font size in all displayed panes, but doesn't allow specifying monospace or a particular font, where certain letters & numerals don't look identical. It also increases size of window controls, scroll bars along w/ text or code, which isn't wanted.

If I could set the web devtools font properties in Inspector, Debugger, Style Editor & hopefully DOM, that would help a lot.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Oct 26, 2019

@m4n8tpr4
The width is controlled by --ac_popup_width variable, you will have to modify it.

The search area at the bottom does not get crushed in my tests.
I will add some more tweaks on next update, that might improve things. Test this code:

/* reduce space around search engines */
#urlbar .search-one-offs {
  padding-top: 0px !important;
  padding-bottom: 0px !important;
  padding-inline-start: 4px !important;
  padding-inline-end: 0px !important;
}

@Infernoflower
For testing purposes disable inside your Windows 10 ui/color settings to colorization of titlebar.
I'm still not sure, if that is what causing the glitch. Have you tested a new CustomCSSforFx setup of your /chrome/ folder?

@ImSpecial
You can set different colors here https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/css/locationbar/ac_popup_classic_with_url_only_fx68.css#L132 and here https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/css/locationbar/ac_popup_classic_with_url_only_fx68.css#L144

@bendover22
Worked fine for me (in Fx72 Nightly).
I used "Freestyle Script" for this example and every area of developer tools was affected.

\chrome_debugger_profile\chrome\userChrome.css -->

* {
  font-size: 14pt !important;
  font-family: "Freestyle Script" !important;
  font-style: italic !important; 
}

-->

font

@RafalRambo
Copy link

Hello.

  1. Is there any website where you can download configurations with photos of what it looks like.
  2. Is it possible to make this modification in the same way as the "Enterprise Policy Generator" plugin is made in which options are selected and a file with these settings is generated later. It would be similar to the old CTR.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Oct 26, 2019

@RafalRambo
Short answer to both: no.

However there are a few screenshots here on Github: #2

I do not have the time or the will to create a "generator"/software/plugin etc. for this projects files.

@jmcken1
Copy link

jmcken1 commented Oct 27, 2019

@Aris-t2 I just updated FF to v70.0 and updated CustomCSS to v2.7.9. Everything works, but as @m4n8tpr4 mentioned, the URL text on the left in the location bar dropdown is now way smaller (though the titles on the right seem possibly unchanged).

Is there a way to make the dropdown URLs text bigger, as it was before v70?
image

@AMGPilot
Copy link

@Aris-t2 First I want to thank you for all of the work you do to support Firefox :)

My question is: How do I change the text color in my bookmarks?

Since the update to Firefox 70 the background of my bookmarks is dark now, which I really like, but the text and arrows are still black and I would like to change it to White if I could.

Here is a pic of my browser with Bookmarks shown:

Bookmark Text Color

Thanks!!

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Oct 27, 2019

@jmcken1
I will add an option for this on next update. In my opinion the text size in general is too small inside that popup.

#urlbar-results :-moz-any(.urlbarView-tags, .urlbarView-action, .urlbarView-title, .urlbarView-url) {
  font-size: 10pt !important;
}

@AMGPilot
Disable the rule bookmarks_menu_button_popup_classic_appearance.css in userChrome.css.
It does not work correctly atm.

@Achille-Grs
Copy link

Dear @Aris-t2 Hi!
I have a small strange question.
You can copy-paste this url below, and save it like a new bookmark, then you have a notepad.
When open it you can write anything you want.

data:text/html,%20<html%20contenteditable><Title>Notepad</Title>

Is that possible with css to change font family, size, color etc?
1

@m4n8tpr4
Copy link

m4n8tpr4 commented Oct 27, 2019

@Aris-t2

@m4n8tpr4
The width is controlled by --ac_popup_width variable, you will have to modify it.

The search area at the bottom does not get crushed in my tests.

I forgot to mention: the search area crushing into the 25%-75% part only happens if I type in something in the location bar in a pseudo-tab (about:preferences or about:config).

Thanks for the font size solution!

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Oct 27, 2019

@Achille-Grs

Add this to userContent.css (it will most likely affect other websites too):

html[contenteditable] body {
  font-size: 14pt !important;
  font-family: "Freestyle Script" !important;
  font-style: italic !important; 
}

@m4n8tpr4
Test the latest release. I can not reproduce this on Fx70 beta or 72 Nightly.

@AMGPilot
Copy link

AMGPilot commented Oct 27, 2019

@AMGPilot
Disable the rule bookmarks_menu_button_popup_classic_appearance.css in userChrome.css.
It does not work correctly atm.

@Aris-t2 Thank you very much for the reply, it works great now! The text and arrows are white just like I wanted.

One more thing... after disabling the classic appearance I now have "Show All Bookmarks at the top and Bottom now. Is there a way top disable the one at the bottom?

Thank you for all of your hard work!!!

..............................Follow Up......................

Holy crap I figured it out on my own!! 🎉

Hopefully I did it correctly.

I added the code below to this file: "bookmarks_menu_button_popup_other_item_hidden.css"

#BMB_bookmarksShowAll,
#BMB_viewBookmarksSidebar {
display: none !important;
}

This removed the "Show All Bookmarks" from the bottom of the Bookmarks popup.

@Infernoflower
Copy link

Infernoflower commented Oct 27, 2019

I just remembered that I actually applied the red colour to the toolbar and header via the Windows personalization colour settings. Should I set the window colour back to its default value in Settings so that the gap between the tabs and the toolbar goes away?

@TroudhuK
Copy link

TroudhuK commented Oct 27, 2019

image
How to display and valid these messages? It appears too furtively and I can't click on "I understand". I don't know what keyword to search to fix that.

@nollinvoyd
Copy link

@Aris-t2

@nollinvoyd

#PopupSearchAutoComplete,
#PopupSearchAutoComplete * {
  color: black !important;
}

The the suggestion font colors are dark, but the search engine colors didn't change. Also, how can this void below the suggestions be removed?

It doesn't allow me to see all my search engines.

search menu

@Crybal
Copy link

Crybal commented Oct 27, 2019

In v.68 esr the unread/unload color for tabs does not work.Is there a way to bring it back?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Oct 28, 2019

@Infernoflower
Try to set your settings back to default and test.

@TroudhuK
Create a new browser profile and test.

@nollinvoyd
Looks like you are using the wrong option.

/* @import "./css/generalui/searchbar_popup_engines_show_labels_fx66.css"; /**/
/* @import "./css/generalui/searchbar_popup_engines_show_labels_fx70.css"; /**/
/* @import "./css/generalui/searchbar_popup_engines_show_labels_fx72.css"; /**/

Make sure you have set the one required by your Fx version and also verify, that you are using the latest files.

About the text color, this is how applying the code looks for me:
search

@Crybal
"unread" state was removed in Fx 61/62 and we can not restore ist. "unload" state aka "pending" still works fine up to Fx72.

@TroudhuK
Copy link

TroudhuK commented Oct 28, 2019

image
(in a new profile)
So it's because I hide this Chrome-like "hamburger" button. Can we find a way to fix that (hide button but show these bubbles)?

@kanade96
Copy link

Hey Aris, I have encountered two issues with the latest release (v2.8.0 with FF 70.0).

1) The back/forward buttons are overlapping for any new pages with no back histories. Is there a way to fix this?
325265
FYI, I'm using the following settings:

  • /css/buttons/icons_white_icons.css
  • /css/buttons/forward_button_hide_when_disabled.css
  • /css/buttons/custom_backforward_connected_to_location_bar

2) I'm currently using "/css/locationbar/ac_popup_classic_with_two_lines_fx68_star_at_the_end.css" for popup content and for some reason, the lines for adjusting the width/height of the box doesn't seem to work.
The lines that I've included in the .css file are:
/* for ac_popup_classic_with_two_lines_fx68.css /
:root {
--ac_popup_width: 700px !important; /
popup width in normal mode /
--ac_popup_width_maximized: 1050px !important; /
popup width in maximized mode /
--ac_popup_width_fullscreen: 1400px !important; /
popup width in fullscreen mode /
--ac_popup_number_of_results: 10 !important; /
value has to be identical to about:config > browser.urlbar.maxRichResults /
--ac_popup_maxheight: calc(47.5px * ( var(--ac_popup_number_of_results) + 1 )) !important; /
calculate maximum height based on items to display /
--ac_popup_height: auto !important; /
replace auto with 'calc(47.5px * var(--ac_popup_number_of_results))' to get a shorter scrollable list for high result numbers */
}

@rayman89
Copy link

@Aris-t2 Are any custom JS methods working atm? I tried method 2 and 3 and none works for me. I assume method 1 is obsolete by now as well.... (?).

@Acid-Crash
Copy link

Hi @rayman89,
I use method 2 (installed according to the CustomJSforFx readme).
Works fine for me on both 70 and 72. I'm on Win10

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Oct 28, 2019

@TroudhuK

You could try this:

#PanelUI-button {
    visibility: hidden !important;
    -moz-margin-end: -28px !important;
}

@kanade96
I will look into the back/forward button issue.

Regarding your second question you have to use variables inside general_variables.css file.
https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/css/locationbar/ac_popup_classic_with_two_lines_fx68.css#L6
https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/css/locationbar/ac_popup_classic_with_two_lines_fx64_star_at_the_end.css#L10

@rayman89
Methods 1 and 3 got updated in the last few month. They should work, but I have not tested them.

@nollinvoyd
Copy link

@Aris-t2

@nollinvoyd
Looks like you are using the wrong option.

/* @import "./css/generalui/searchbar_popup_engines_show_labels_fx66.css"; /**/
/* @import "./css/generalui/searchbar_popup_engines_show_labels_fx70.css"; /**/
/* @import "./css/generalui/searchbar_popup_engines_show_labels_fx72.css"; /**/

I have Firefox 70. I was using
@import "./css/generalui/searchbar_popup_engines_show_labels_fx70.css"; /**/

It only works properly when I use
/* @import "./css/generalui/searchbar_popup_engines_show_labels_fx72.css"; /**/

Make sure you have set the one required by your Fx version and also verify, that you are using the latest files.

About the text color, this is how applying the code looks for me:
search

I put it in my_userChrome.css. I tried changing it from black to blue to see if it would work, but it just stays grey

#PopupSearchAutoComplete, #PopupSearchAutoComplete * { color: blue !important; }

@nollinvoyd
Copy link

Can these entries from the location bar suggestions be closer together

location

@VcSaJen
Copy link

VcSaJen commented Jan 12, 2020

Firefox Developer Edition 73.0b3, about:addons, about:preferences are broken (some text is cut off, some images are stretched with wrong aspect ratio).

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 12, 2020

@ooofest
This is strange, because the code still works fine here even in the latest Nightly (Fx74) with and without lw-themes.

Try this workaround, it should work too.

toolbar toolbarspring {
  min-width: 1px !important;
  max-width: 1px !important;
  -moz-margin-start: 1px !important;
  border-right: 0.5px solid !important;
  border-left: 0.5px solid !important;
  margin-top: 4px !important;
  margin-bottom: 4px !important;
}

@VcSaJen
Post screenshots.

@ooofest
Copy link

ooofest commented Jan 12, 2020

@Aris-t2 Your workaround works, thank you!

I tried going back to the older specification and re-confirmed it's not working in this browser, btw.

The separator bars seem a bit more white/solid in this case, but still much better visually for me than the blank, variable spacing we get by default in Firefox these days.

@AbdAbd10
Copy link

hi. after making the flexible space for picking the item side if you want them to the right or to the left there is no way to create a space between the items and if you have item that has a numbers the numbers going to be on top of the the other item
Untitled

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 13, 2020

If you are using the simulated add-on bar, this will help:

#PersonalToolbar toolbarbutton .toolbarbutton-badge {
  -moz-margin-end: -1px !important;
  margin-top: -4px !important;  
  padding: 1px !important;
  min-width: unset !important;
  font-size: 9px !important;
}

@krystian3w
Copy link
Contributor

krystian3w commented Jan 13, 2020

Something is bugged in your code to override indicators...? Completely does not work on TabsToolbar.

Now I use this:

#PlacesToolbarDropIndicator,
#TabsToolbar .tab-drop-indicator {
  margin-top: 15px !important;
  height: 7px !important;
  width: 9px !important;
  list-style-image: url(./image/dropdown-arrow-inverted.svg) !important;
}

#PlacesToolbarDropIndicator {
  margin-top: 20px !important;
}

@TroudhuK
Copy link

TroudhuK commented Jan 13, 2020

Bug since Fx70:
If we open a window without menubar while the menubar is displayed in the normal window, it's not hidden.
image
same window but maximized:
image

Use this code to do it (as bookmark for example):
javascript:window.open(window.location.href,"","toolbar=0,menubar=0,location=0")

@AbdAbd10
Copy link

Untitled

it helped thanks

@pro100Hub
Copy link

pro100Hub commented Jan 13, 2020

@Aris-t2
FF72 (about:addons)

  1. Please help how can I return the standard style for this pop-up window?
    2020-01-13_21-20-24
    This window is affected by the global rule for all buttons in the file addonlists_replace_button_labels_with_icons_fx72.css:

link:-moz-any([href$="panel-item.css"],[href$="panel-list.css"]) ~ button {

  1. In the Plugins section, I noticed that the buttons overlap the text, how can this be fixed?
    firefox_2020-01-13_21-19-58

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 13, 2020

@krystian3w
The code was for buttons on bookmarks toolbar.

@TroudhuK
Does this happen without any CSS modifications too?

@pro100Hub

  1. You can't. Its a side effect of the combination of addonlists_show_buttons_instead_of_menu_popup_fx72.css + addonlists_replace_button_labels_with_icons_fx72.css
  2. Same as above.

@pro100Hub
Copy link

pro100Hub commented Jan 13, 2020

@Aris-t2

  1. You can't. Its a side effect of the combination of addonlists_show_buttons_instead_of_menu_popup_fx72.css + addonlists_replace_button_labels_with_icons_fx72.css
  2. Same as above.

It's a pity(((

Is it possible to swap these blocks? To gear was the first.
firefox_2020-01-13_22-28-05

@krystian3w
Copy link
Contributor

krystian3w commented Jan 13, 2020

The code was for buttons on bookmarks toolbar.

#241 (comment)

but .tab-drop-indicator I found only in #TabsToolbar.


@Speravir There is no thread about new indicator on the your forum?
I assume that you will have to manually convert the SVG - to flip the arrow, and the CSS can't move under bars better.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 13, 2020

@pro100Hub

	.main-heading .page-options-menu {
	  order: -1;
	}

@krystian3w
Sorry, forget my last post, I though your reply was about something else ;-)
The code might or might not work on every Fx build. I have not tested it everywhere.

@krystian3w
Copy link
Contributor

The worst is calculating margin-top: 💯.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 13, 2020

What about creating a custom image of the same size the vanilla version in current Fx uses?
One could use transparency to "fill" the non-required areas of the image keeping original required sizes. That way there is no recalculation required (or at least I think it is not ;-)).

@TroudhuK
Copy link

TroudhuK commented Jan 13, 2020

@Aris-t2

Does this happen without any CSS modifications too?

It's worst: I see the menubar AND the location bar (read only). With an empty chrome folder, or a v2.9.9_v2 without modification.
So it's because of Firefox...

EDIT : Sorry, for the location bar I forgot dom.disable_window_open_feature.location=false, and the problem is gone. Investigation...

@Speravir
Copy link

@krystian3w

@Speravir There is no thread about new indicator on the your forum?
I assume that you will have to manually convert the SVG - to flip the arrow, and the CSS can't move under bars better.

Sorry, I can not follow, what do you refer to?

@krystian3w
Copy link
Contributor

krystian3w commented Jan 14, 2020

About override this 💩: #241 (comment)

obraz

https://www.camp-firefox.de/suche/

Es wurde kein mit deiner Suchanfrage „Indicator“ übereinstimmender Eintrag gefunden.

Null.

@TroudhuK
Copy link

About

Bug since Fx70:
If we open a window without menubar while the menubar is displayed in the normal window, it's not hidden.
image
same window but maximized:
image

Use this code to do it (as bookmark for example):
javascript:window.open(window.location.href,"","toolbar=0,menubar=0,location=0")

=> It's because of themes. When I have a theme (https://addons.mozilla.org/fr/firefox/addon/white00/), this space appears, and if I uncheck the menu bar to hide it, it's emplacement stays (only the text disappears).
It should be patchable from userChromeCSS...

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 14, 2020

Sounds like something for the Fx bug reporting area on Bugzilla.

@Speravir
Copy link

@krystian3w Aah, it was some kind of question. Your link was useless (self link to this issue), but with the image you posted I found your question from 6 days ago (it was hidden because of the amount of reactions here).

Apparently, noone in Camp Firefox is annoyed by this new indicator or noone noticed it until now. (BTW: It is not my forum, I am just an active contributor there.)

Where is #PlacesDropIndicator supposed to be displayed? I only get the 'tab-drag-indocator-image', so the .tab-drag-indicator.

Could transform: scaleY(-1) be used instead of own inverted images? (Did not test myself, also ping @Aris-t2.)

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 14, 2020

@Speravir
The #PlacesDropIndicator is visible when bookmarks are moved within bookmarks toolbar.

I think @krystian3w tries to restore the old dropmarker, which was a tiny arrow using a small image. The new one has a bigger vertical size.
I suggested to create a new transparent image of the same size the new dropmarker uses and add the "old" arrow to the bottom of it. (I haven't tested this.)

@krystian3w
Copy link
Contributor

png version.zip

IMO need smaller image or hack with this:

#TabsToolbar .tab-drop-indicator {
	max-height: var(--classic_squared_tabs_tab_height) !important;
}

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 15, 2020

Continue here #273

@Aris-t2 Aris-t2 closed this as completed Jan 15, 2020
@Aris-t2 Aris-t2 unpinned this issue Jan 15, 2020
Repository owner locked as too heated and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests