Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Improve settings menu UX #289

Merged
merged 5 commits into from Sep 28, 2017
Merged

Improve settings menu UX #289

merged 5 commits into from Sep 28, 2017

Conversation

j-a-m-l
Copy link
Contributor

@j-a-m-l j-a-m-l commented Sep 23, 2017

Before:

settings-menu-before

After:

settings-menu-after

I've discovered that there are 2 missing translations:

  • Currency
  • Play song when receive funds?

@boldninja
Copy link
Member

Can we change text from 'Play song when receive funds' to 'Play sound when receiving transaction?' @j-a-m-l

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Sep 27, 2017

@boldninja done!

@boldninja
Copy link
Member

song = sound :)

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Sep 27, 2017

@boldninja done ;)

@luciorubeens luciorubeens merged commit b42e95f into ArkEcosystem:master Sep 28, 2017
@luciorubeens
Copy link
Contributor

great! +5 👍🏻

alexbarnsley pushed a commit that referenced this pull request Dec 3, 2018
* fix: remove the usage of the `wallets` prop of `WalletSidebar`
* fix: remove the example dashboard component of `electron-vue`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants