Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

[Lint] Format code #376

Merged
merged 1 commit into from Oct 31, 2017
Merged

[Lint] Format code #376

merged 1 commit into from Oct 31, 2017

Conversation

rbantonio
Copy link

Hi, i formatted the code using the standardjs, this is a lot of changes but I just removed the spaces, the semicolons and other minor changes. So do not worry about merging this or validating each line.. Cheers!

@alexbarnsley
Copy link
Member

I wish I could explain why no semi-colons bothers me so much. I know it's a standard but it just doesn't feel right 😂

@rbantonio
Copy link
Author

@alexbarnsley I've the same feeling, unfortunately it's the standard 😢

@alexbarnsley
Copy link
Member

😩

im-not-mad-just-disappointed

@luciorubeens
Copy link
Contributor

Hmm it seems that nobody here wants to remove the semicolons, I think that instead of the standardjs we can use the eslint with our rules..

@boldninja
Copy link
Member

Oh look at the boys making their own standards who is cool now

semicolumn

@alexbarnsley
Copy link
Member

I did find this when trying to find out why get rid of semicolons in case anyone is interested: https://github.com/Flet/semistandard

@boldninja leave the developers to talk important things 😂

@krau612
Copy link

krau612 commented Oct 30, 2017

Not the semicolons! 😭

jk I actually don't mind getting rid of them lol

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Oct 30, 2017

The idea of using a standard is to avoid personal preferences. StandardJS is an attempt to have a unique style that is shared between lots of projects, not just standard per project or per organization.

Anyway, I don't care too much about using 1 style or another, but semicolons are almost useless, so why adding them when it's not necessary?

@zillionn
Copy link
Contributor

Because you're used to use semicolons when you write in other languages.

@alexbarnsley
Copy link
Member

Agree with @zillionn, there are more languages with a semi than not. For me as well (yes preference), a semi colon visually tells the developer it's the end of a statement.

I'm all for a standard and keeping everything consistent though, and will get used to whatever is used

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Oct 31, 2017

@zillionn I'm used to languages that don't use semicolons (Ruby, Python...) so to me and more people that isn't a valid argument because different people have different background. So the standard should be for JS only, not thinking about other languages.

For me, an argument that is independent of the personal background would be @alexbarnsley position. But I think that it has a big flaw, because all JS developers know that the end of a line is visually the end of the statement, so adding a ; at the end of the line doesn't add any special meaning.

IMHO it's just a reminiscence of the times when JS developers didn't know how to use them (http://inimino.org/%7Einimino/blog/javascript_semicolons). Are we going to perpetuate this misleading tradition?

It's impossible to create a standard that all people love, so maybe it's better to use 1 that it's used in more projects although we don't like all their decisions (I don't like several of them), than creating a new one and discussing about our personal preferences.

As you can see here, StandardJS is used by lots of companies and projects that are important in the JS ecosystem: https://standardjs.com/index.html#who-uses-javascript-standard-style and https://raw.githubusercontent.com/standard/standard-packages/master/all.json

@zillionn
Copy link
Contributor

That was just my opinion. I don't have much time to contribute so it's not up to me. Probably the people who contribute most should decide which standard to use.

@luciorubeens luciorubeens merged commit 2cb64a4 into ArkEcosystem:master Oct 31, 2017
@luciorubeens
Copy link
Contributor

"Are we going to perpetuate this misleading tradition?" 😂

@j-a-m-l Ok, you convinced me. Let's get used!

semicolon

@Noahgr +5! 👍🏻

@alexbarnsley
Copy link
Member

That meme 😂

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Nov 2, 2017

I've to admit that the real reason for using StandardJS is adding a badge...

StandardJS

@rbantonio rbantonio deleted the code-format branch November 3, 2017 01:26
@j-a-m-l j-a-m-l mentioned this pull request Nov 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants