fix(core-p2p): limit peers returned by getPeers

ArkEcosystem · Dec 11, 2020 · 4c79c45 · 4c79c45
1 parent 9370175
commit 4c79c45
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/packages/core-p2p/src/constants.ts b/packages/core-p2p/src/constants.ts
@@ -3,4 +3,5 @@ export const constants = {
     DEFAULT_MAX_PAYLOAD: 20 * 1024 * 1024, // default maxPayload value on the server WS socket
     DEFAULT_MAX_PAYLOAD_CLIENT: 100 * 1024, // default maxPayload value on the client WS socket
     KILOBYTE: 1024,
+    MAX_PEERS_GETPEERS: 2000,
 };
diff --git a/packages/core-p2p/src/schemas.ts b/packages/core-p2p/src/schemas.ts
@@ -1,4 +1,5 @@
 import { app } from "@arkecosystem/core-container";
+import { constants } from "./constants";
 
 export const requestSchemas = {
     peer: {
@@ -100,7 +101,7 @@ export const replySchemas = {
     },
     "p2p.peer.getPeers": {
         type: "array",
-        maxItems: 2000,
+        maxItems: constants.MAX_PEERS_GETPEERS,
         items: {
             type: "object",
             properties: {

diff --git a/packages/core-p2p/src/socket-server/versions/peer.ts b/packages/core-p2p/src/socket-server/versions/peer.ts
@@ -3,6 +3,7 @@ import { Blockchain, Database, Logger, P2P, TransactionPool } from "@arkecosyste
 import { isBlockChained } from "@arkecosystem/core-utils";
 import { Blocks, Crypto, Interfaces } from "@arkecosystem/crypto";
 import pluralize from "pluralize";
+import { constants } from "../../constants";
 import { MissingCommonBlockError } from "../../errors";
 import { IPeerPingResponse } from "../../interfaces";
 import { isWhitelisted } from "../../utils";
@@ -15,6 +16,7 @@ export const getPeers = ({ service }: { service: P2P.IPeerService }): P2P.IPeerB
         .getStorage()
         .getPeers()
         .sort((a, b) => a.latency - b.latency)
+        .slice(0, constants.MAX_PEERS_GETPEERS)
         .map(peer => peer.toBroadcast());
 };