fix: always deserialize vendor field

ArkEcosystem · Jun 7, 2019 · b537d6f · b537d6f
1 parent 5137ca3
commit b537d6f
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/crypto/src/transactions/deserializer.ts b/packages/crypto/src/transactions/deserializer.ts
@@ -57,7 +57,9 @@ class Deserializer {
         const vendorFieldLength: number = buf.readUint8();
         if (vendorFieldLength > 0) {
             if (transaction.hasVendorField()) {
-                transaction.data.vendorFieldHex = buf.readBytes(vendorFieldLength).toString("hex");
+                const vendorFieldBuffer: Buffer = buf.readBytes(vendorFieldLength).toBuffer();
+                transaction.data.vendorFieldHex = vendorFieldBuffer.toString("hex"); // TODO: purpose?
+                transaction.data.vendorField = vendorFieldBuffer.toString("utf8");
             } else {
                 buf.skip(vendorFieldLength);
             }
@@ -158,10 +160,6 @@ class Deserializer {
                 k.startsWith("+") ? k : `+${k}`,
             );
         }
-
-        if (transaction.vendorFieldHex) {
-            transaction.vendorField = Buffer.from(transaction.vendorFieldHex, "hex").toString("utf8");
-        }
     }
 
     private getByteBuffer(serialized: Buffer | string): ByteBuffer {