Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose to the api whether peer uses estimates or not #3592

Closed
dated opened this issue Mar 9, 2020 · 5 comments
Closed

feat: expose to the api whether peer uses estimates or not #3592

dated opened this issue Mar 9, 2020 · 5 comments
Assignees

Comments

@dated
Copy link
Contributor

dated commented Mar 9, 2020

Currently the only way to find out if a peer uses estimates under the hood is by sending a request to it and check the responses meta object for the totalCountIsEstimate property.

"meta": {
  "totalCountIsEstimate": true,
}

This information should also be included in the peers api response, so that peers can be easily filtered by that property instead of having to query each peer individually if one with need to assemble a list of such peers.

This could then also be implemented into into the peer discovery package, @arkecosytem/typescript-peers.

@ghost
Copy link

ghost commented Mar 9, 2020

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@stale
Copy link

stale bot commented Apr 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale label Apr 8, 2020
@stale stale bot closed this as completed Apr 15, 2020
@ghost
Copy link

ghost commented Apr 15, 2020

This issue has been closed. If you wish to re-open it please provide additional information.

@ghost ghost removed the Status: Stale label Apr 15, 2020
@faustbrian faustbrian reopened this Apr 16, 2020
@ghost
Copy link

ghost commented Apr 16, 2020

This issue has now been re-opened. If applicable please provide additional information as requested by one of the reviewers.

@stale
Copy link

stale bot commented May 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants