Core v3: possible peer verification issue involving p2p getBlocks and getCommonBlocks

[adrian69]

Expected Behavior

Core should sync up to height after restart.

Current Behavior

If restarted, it will refuse downloading blocks form any other peer on the network, thinking they are on different chain:

0|ark  | [2020-06-08 09:32:44.502] DEBUG: Checking ports of 50 peers.
0|ark  | [2020-06-08 09:32:44.530] INFO : Checking 50 peers
0|ark  | [2020-06-08 09:32:44.537] INFO : 50 of 50 peers on the network are responsive
0|ark  | [2020-06-08 09:32:44.538] INFO : Median Network Height: 29,897
0|ark  | [2020-06-08 09:32:44.538] INFO : Discovered 50 peers with v3.0.0-next.0.
0|ark  | [2020-06-08 09:32:45.539] DEBUG: event 'STARTED': "init" -> {"syncWithNetwork":"syncing"} -> actions: [checkLastDownloadedBlockSynced]
0|ark  | [2020-06-08 09:32:45.540] DEBUG: Queued chunks of blocks (process: 0)
0|ark  | [2020-06-08 09:32:45.541] DEBUG: event 'NOTSYNCED': {"syncWithNetwork":"syncing"} -> {"syncWithNetwork":"downloadBlocks"} -> actions: [downloadBlocks]
0|ark  | [2020-06-08 09:32:45.542] ERROR: Could not download blocks: We have 50 peer(s) but all of them are on a different chain than us
0|ark  | [2020-06-08 09:32:45.543] INFO : Could not download any blocks from any peer from height 29895
0|ark  | [2020-06-08 09:32:45.543] DEBUG: event 'NOBLOCK': {"syncWithNetwork":"downloadBlocks"} -> {"syncWithNetwork":"syncing"} -> actions: [checkLastDownloadedBlockSynced]
0|ark  | [2020-06-08 09:32:45.544] DEBUG: Queued chunks of blocks (process: 0)
0|ark  | [2020-06-08 09:32:45.545] DEBUG: event 'NOTSYNCED': {"syncWithNetwork":"syncing"} -> {"syncWithNetwork":"downloadBlocks"} -> actions: [downloadBlocks]
0|ark  | [2020-06-08 09:32:45.545] ERROR: Could not download blocks: We have 50 peer(s) but all of them are on a different chain than us
0|ark  | [2020-06-08 09:32:45.546] INFO : Could not download any blocks from any peer from height 29895
0|ark  | [2020-06-08 09:32:45.546] DEBUG: event 'NOBLOCK': {"syncWithNetwork":"downloadBlocks"} -> {"syncWithNetwork":"syncing"} -> actions: [checkLastDownloadedBlockSynced]
0|ark  | [2020-06-08 09:32:45.547] DEBUG: Queued chunks of blocks (process: 0)
0|ark  | [2020-06-08 09:32:45.547] DEBUG: event 'NOTSYNCED': {"syncWithNetwork":"syncing"} -> {"syncWithNetwork":"downloadBlocks"} -> actions: [downloadBlocks]
0|ark  | [2020-06-08 09:32:45.548] ERROR: Could not download blocks: We have 50 peer(s) but all of them are on a different chain than us
0|ark  | [2020-06-08 09:32:45.548] INFO : Could not download any blocks from any peer from height 29895
0|ark  | [2020-06-08 09:32:45.548] DEBUG: event 'NOBLOCK': {"syncWithNetwork":"downloadBlocks"} -> {"syncWithNetwork":"syncing"} -> actions: [checkLastDownloadedBlockSynced]
0|ark  | [2020-06-08 09:32:45.551] DEBUG: Queued chunks of blocks (process: 0)
0|ark  | [2020-06-08 09:32:45.551] DEBUG: event 'NOTSYNCED': {"syncWithNetwork":"syncing"} -> {"syncWithNetwork":"downloadBlocks"} -> actions: [downloadBlocks]
0|ark  | [2020-06-08 09:32:45.552] ERROR: Could not download blocks: We have 50 peer(s) but all of them are on a different chain than us
0|ark  | [2020-06-08 09:32:45.552] INFO : Could not download any blocks from any peer from height 29895
0|ark  | [2020-06-08 09:32:45.553] DEBUG: event 'NOBLOCK': {"syncWithNetwork":"downloadBlocks"} -> {"syncWithNetwork":"syncing"} -> actions: [checkLastDownloadedBlockSynced]
0|ark  | [2020-06-08 09:32:45.553] DEBUG: Queued chunks of blocks (process: 0)
0|ark  | [2020-06-08 09:32:45.554] DEBUG: event 'NOTSYNCED': {"syncWithNetwork":"syncing"} -> {"syncWithNetwork":"downloadBlocks"} -> actions: [downloadBlocks]
0|ark  | [2020-06-08 09:32:45.554] ERROR: Could not download blocks: We have 50 peer(s) but all of them are on a different chain than us
0|ark  | [2020-06-08 09:32:45.555] INFO : Could not download any blocks from any peer from height 29895
0|ark  | [2020-06-08 09:32:45.555] DEBUG: event 'NOBLOCK': {"syncWithNetwork":"downloadBlocks"} -> {"syncWithNetwork":"syncing"} -> actions: [checkLastDownloadedBlockSynced]
0|ark  | [2020-06-08 09:32:45.555] DEBUG: Queued chunks of blocks (process: 0)
0|ark  | [2020-06-08 09:32:45.556] DEBUG: event 'NOTSYNCED': {"syncWithNetwork":"syncing"} -> {"syncWithNetwork":"downloadBlocks"} -> actions: [downloadBlocks]
0|ark  | [2020-06-08 09:32:45.556] ERROR: Could not download blocks: We have 50 peer(s) but all of them are on a different chain than us
0|ark  | [2020-06-08 09:32:45.557] INFO : Could not download any blocks from any peer from height 29895
0|ark  | [2020-06-08 09:32:45.557] DEBUG: event 'NOBLOCK': {"syncWithNetwork":"downloadBlocks"} -> {"syncWithNetwork":"syncing"} -> actions: [checkLastDownloadedBlockSynced]
0|ark  | [2020-06-08 09:32:45.558] DEBUG: Queued chunks of blocks (process: 0)
0|ark  | [2020-06-08 09:32:45.558] INFO : Tried to sync 5 times to different nodes, looks like the network is missing blocks
0|ark  | [2020-06-08 09:32:45.559] DEBUG: event 'NETWORKHALTED': {"syncWithNetwork":"syncing"} -> {"syncWithNetwork":"end"} -> actions: [syncingComplete]
0|ark  | [2020-06-08 09:32:45.559] INFO : Blockchain 100% in sync
0|ark  | [2020-06-08 09:32:45.560] DEBUG: event 'SYNCFINISHED': {"syncWithNetwork":"end"} -> "idle" -> actions: [checkLater, blockchainReady]
0|ark  | [2020-06-08 09:32:46.447] INFO : Checking 10 peers
0|ark  | [2020-06-08 09:32:46.452] INFO : Public API (HTTP) Server started at http://0.0.0.0:4003

Steps to Reproduce (for bugs)

Simply restart a synced node.

Your Environment

• Version used: v3.0.0-next.0 (branch: develop / commit: 8a2033ac91513db496b6351d7290bf17fa5837ff)