Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting logs Socket error (peer xxxx) : Connection terminated while waiting to connect and peer is not dropped #3903

Closed
air1one opened this issue Jul 21, 2020 · 2 comments
Closed

Getting logs Socket error (peer xxxx) : Connection terminated while waiting to connect and peer is not dropped #3903

air1one opened this issue Jul 21, 2020 · 2 comments
Assignees
@bertiespell @sebastijankuzner

Comments

@air1one
Copy link
Contributor

air1one commented Jul 21, 2020

When we fail to connect to a peer we get a lot of logs like Socket error (peer xxxx) : Connection terminated while waiting to connect and we never drop the peer.

Was supposed to be fixed by #3887 but it seems like we do not catch this connection error so we don't drop the peer.

To be sure that it is fixed, set up two nodes and disconnect them, and see if there are the debug messages.
@sebastijankuzner
Copy link
Contributor

@air1one did you try after this commit? #3901

@air1one
Copy link
Contributor Author

air1one commented Jul 22, 2020

yeah we still have these logs on latest develop.

@sebastijankuzner sebastijankuzner self-assigned this Jul 22, 2020
@sebastijankuzner sebastijankuzner mentioned this issue Jul 23, 2020
Merged
2 tasks
@air1one air1one closed this as completed Jul 25, 2020
@ghost ghost mentioned this issue Jul 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertiespell bertiespell

@sebastijankuzner sebastijankuzner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bertiespell @air1one @sebastijankuzner