Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): disconnect all sockets on peer disconnect #3909

Merged
merged 4 commits into from
Jul 23, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR solves #3903. All pper sockets are closed on peer disconnect.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #3909 into develop will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3909      +/-   ##
===========================================
- Coverage    97.52%   97.46%   -0.06%     
===========================================
  Files          628      628              
  Lines        14526    14531       +5     
  Branches      1727     1728       +1     
===========================================
- Hits         14166    14163       -3     
- Misses         171      177       +6     
- Partials       189      191       +2     
Flag Coverage Δ
#functional 6.77% <0.00%> (+0.01%) ⬆️
#integration ?
#unit 95.71% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/listeners.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/network-monitor.ts 99.62% <100.00%> (-0.01%) ⬇️
packages/core-p2p/src/peer-communicator.ts 100.00% <100.00%> (ø)
...core-database/src/repositories/block-repository.ts 89.04% <0.00%> (-7.89%) ⬇️
packages/core-test-framework/src/app/sandbox.ts 97.43% <0.00%> (-2.57%) ⬇️
packages/core-test-framework/src/utils/api.ts 96.46% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ce984...9ba87cc. Read the comment docs.

air1one
air1one previously approved these changes Jul 23, 2020
@air1one air1one merged commit 95d6b2c into develop Jul 23, 2020
@ghost ghost deleted the fix/core-p2p/disconect-on-forget-peer branch July 23, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants