Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process.env vars should take priority over .env file vars #3933

Closed
air1one opened this issue Aug 5, 2020 · 2 comments
Closed

process.env vars should take priority over .env file vars #3933

air1one opened this issue Aug 5, 2020 · 2 comments
Assignees
@sebastijankuzner

Comments

@air1one
Copy link
Contributor

air1one commented Aug 5, 2020

Any process.env variables that are set should not be overwritten by the variables in .env file, or as Brian put it :

If process.env.BLA_BLA is already set then https://github.com/ArkEcosystem/core/blob/develop/packages/core-kernel/src/services/config/drivers/local.ts#L72 should be skipped
@sebastijankuzner sebastijankuzner self-assigned this Aug 6, 2020
@sebastijankuzner sebastijankuzner mentioned this issue Aug 6, 2020
Merged
1 task
@air1one air1one closed this as completed Aug 7, 2020
@ghost ghost mentioned this issue Aug 9, 2020
Closed
@air1one air1one reopened this Aug 13, 2020
@air1one
Copy link
Contributor Author

air1one commented Aug 13, 2020

Re-opening, see last comment on #3935

@air1one
Copy link
Contributor Author

air1one commented Aug 13, 2020

Re-closing, was fine after all 😄

@air1one air1one closed this as completed Aug 13, 2020
@ghost ghost mentioned this issue Aug 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastijankuzner sebastijankuzner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@air1one @sebastijankuzner