Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): too many open files #3957

Closed
wants to merge 11 commits into from

Conversation

rainydio
Copy link
Contributor

Summary

Tracking down core-p2p test failure.

@ghost ghost added Complexity: High labels Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #3957 into develop will decrease coverage by 83.80%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3957       +/-   ##
============================================
- Coverage    97.56%   13.76%   -83.81%     
============================================
  Files          629      629               
  Lines        14541    14540        -1     
  Branches      1730     1729        -1     
============================================
- Hits         14187     2001    -12186     
- Misses         165    12424    +12259     
+ Partials       189      115       -74     
Flag Coverage Δ
#functional 6.82% <ø> (+<0.01%) ⬆️
#integration 9.85% <ø> (+<0.01%) ⬆️
#unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/src/cli.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/schemas.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/commands/top.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-cli/src/contracts.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-forger/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/listeners.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/commands/help.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-manager/src/events.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 560 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39894a4...626ea3a. Read the comment docs.

@rainydio rainydio closed this Aug 13, 2020
@ghost ghost removed the Status: In Progress label Aug 13, 2020
@rainydio rainydio deleted the fix/core-p2p/too-many-open-files-2 branch August 13, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant