Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): out of memory test error #3960

Closed
wants to merge 5 commits into from

Conversation

rainydio
Copy link
Contributor

Summary

Tracking down core-p2p out of memory error in tests.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #3960 into develop will decrease coverage by 1.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3960      +/-   ##
===========================================
- Coverage    97.53%   95.80%   -1.74%     
===========================================
  Files          629      629              
  Lines        14540    14540              
  Branches      1729     1729              
===========================================
- Hits         14182    13930     -252     
- Misses         167      421     +254     
+ Partials       191      189       -2     
Flag Coverage Δ
#functional ?
#integration 9.85% <0.00%> (?)
#unit 95.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/migrations/20190307000000-drop-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305200000-create-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305300000-create-blocks-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../migrations/20180305100000-create-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...igrations/20190626000000-enforce-chained-blocks.ts 0.00% <0.00%> (-100.00%) ⬇️
...rations/20191003000000-migrate-vendor-field-hex.ts 0.00% <0.00%> (-100.00%) ⬇️
...ations/20180305400000-create-transactions-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../20190718000000-check_previous_block-add-schema.ts 0.00% <0.00%> (-100.00%) ⬇️
...20190619000000-drop-id-column-from-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...81204200000-add-timestamp-index-to-blocks-table.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3565ef5...f5bcc39. Read the comment docs.

@rainydio rainydio changed the title Log heap usage fix(core-p2p): out of memory test error Aug 13, 2020
@rainydio
Copy link
Contributor Author

It appears that problem mysteriously disappeared.

@rainydio rainydio closed this Aug 14, 2020
@ghost ghost removed the Status: In Progress label Aug 14, 2020
@rainydio rainydio deleted the fix/core-p2p/out-of-memory-tests-1 branch August 14, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant