Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move packages out of source #140

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@sleepdefic1t
Copy link
Member

commented Oct 7, 2019

Summary

External libraries are currently submoduled in the source tree which leads to more complex builds and makes maintaining and debugging more difficult.

This PR moves external libraries to extern in the root dir and drops submodules in favor CMake methods of fetching dependencies.

Specifically, this PR does the following:

  • removes all git submodules.
  • adds CMake configs to get extern libs.
  • updates CMake configurations and naming.
  • makes building tests optional.
  • updates build scripts.
  • updates Actions/CI scripts and workflow.
  • updates PIO configuration files.
  • updates the Arduino IDE helper script.
  • updates the changelog.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Additional Comments

PIO build failure is resolved in #139

@faustbrian

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@sleepdefic1t platformio failing

@faustbrian faustbrian merged commit 4d99aae into ArkEcosystem:develop Oct 8, 2019
5 checks passed
5 checks passed
arduino
Details
platformio
Details
linux-gcc7
Details
linux-clang-5
Details
macos
Details
@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:chore/move-packages-oos branch Oct 8, 2019
sleepdefic1t added a commit to sleepdefic1t/cpp-client that referenced this pull request Oct 9, 2019
### Added
-   added Blockchain API endpoint (ArkEcosystem#104)

### Changed
-   improved API query usage to accept strings (ArkEcosystem#114)
-   improved class members and test coverage (ArkEcosystem#93)
-   improved formatting and maintainability (ArkEcosystem#92)
-   dropped Hunter Package Manager in favor of git submodules in OS builds (ArkEcosystem#90)
-   updated ArduinoJson 5.13.2 >> 6.10.1, usage patterns, and documentation/examples (ArkEcosystem#87)
-   moved external libraries out of source tree (ArkEcosystem#140)

### Fixed
-   fixed typos in Arduino examples (ArkEcosystem#86)
-   changed to "statusCode" '422' to test API Post response for empty Transactions objects (ArkEcosystem#85)
@sleepdefic1t sleepdefic1t referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.