Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move packages out of source #140

Merged
merged 3 commits into from
Oct 8, 2019
Merged

chore: move packages out of source #140

merged 3 commits into from
Oct 8, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Summary

External libraries are currently submoduled in the source tree which leads to more complex builds and makes maintaining and debugging more difficult.

This PR moves external libraries to extern in the root dir and drops submodules in favor CMake methods of fetching dependencies.

Specifically, this PR does the following:

  • removes all git submodules.
  • adds CMake configs to get extern libs.
  • updates CMake configurations and naming.
  • makes building tests optional.
  • updates build scripts.
  • updates Actions/CI scripts and workflow.
  • updates PIO configuration files.
  • updates the Arduino IDE helper script.
  • updates the changelog.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Additional Comments

PIO build failure is resolved in #139

@faustbrian
Copy link
Contributor

@sleepdefic1t platformio failing

@faustbrian faustbrian merged commit 4d99aae into ArkEcosystemArchive:develop Oct 8, 2019
@sleepdefic1t sleepdefic1t deleted the chore/move-packages-oos branch October 8, 2019 17:51
@sleepdefic1t sleepdefic1t mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants