Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] chore: Drop Hunter Package Manager #89

Closed
wants to merge 22 commits into from
Closed

[WIP] chore: Drop Hunter Package Manager #89

wants to merge 22 commits into from

Conversation

sleepdefic1t
Copy link
Contributor

@sleepdefic1t sleepdefic1t commented May 13, 2019 •
edited
Loading

Proposed changes

This PR drops Hunter Package Manager in favor of git submodules.

Specifically, this PR does the following:

  • drops Hunter & Hunter files.
  • adds cURL git submodule.
  • updates CMakeLists.txt files to find cURL dep.
  • updates relevant documentation.
  • updates the changelog.

This also resolves #45

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

@sleepdefic1t
chore: Drop Hunter Package Manager
6dbd04b 
Use git submodules in favor of Hunter Package Manager.

- drop Hunter & files.
- add cURL git submodule.
- update Cmake v3.2.2 >> v3.14.3.
- update CMakeLists.txt files to reflect changes.
- update relevant documentation.
- update changelog
@ghost ghost added Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels May 13, 2019
@ghost
Copy link

ghost commented May 13, 2019 •
edited by ghost
Loading

The ci/circleci: build-linux-gcc7 job is failing as of 050005e4c7c4c612e5edc90f47d7b71b48b96bd5. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ghost
Copy link

ghost commented May 13, 2019

The ci/circleci: build-linux-gcc7 job is failing as of 6dbd04b75ffc626db93a88a3760442db8a297f07. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t sleepdefic1t changed the title chore: Drop Hunter Package Manager [WIP] chore: Drop Hunter Package Manager May 14, 2019
@sleepdefic1t sleepdefic1t deleted the chore/drop-hunter branch May 16, 2019 02:24
@ghost ghost mentioned this pull request May 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor curl dependency
1 participant
@sleepdefic1t