Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bip39 languages #30

Merged

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Nov 27, 2018

Proposed changes

Added support for additional BIP39 languages for passphrase generation.

New Languages:

  • Spanish
  • French
  • Italian
  • Japanese
  • Korean
  • Traditional Chinese
  • Simplified Chinese

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Added bulk support for this feature in BIP39 submodule. Changed macro code generation for putting dictionaries into program memory into actual code generation via separate application (make_dictionary). The application and the generated code from the application are checked into the repo. Added more test coverage pulled from BIP39 recommend test vectors.

Update BIP39 to pull in support new languages.
Add support for additional BIP39 languages.
Enlarged test passphrase buffer to hold the maximum potential length of passphrase
Convert gtest wrapper for AUnit to use built in adapter.
sleepdefic1t
sleepdefic1t previously approved these changes Nov 29, 2018
Copy link
Contributor

@sleepdefic1t sleepdefic1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Nice work!

@sleepdefic1t
Copy link
Contributor

This can be merged.

@faustbrian
Copy link
Contributor

@ciband conflicts

@ciband
Copy link
Contributor Author

ciband commented Nov 30, 2018

@faustbrian done

@faustbrian faustbrian merged commit 8d0c6c4 into ArkEcosystemArchive:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants